Skip to content

chore: upgrade to typescript-eslint v8 #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025

Conversation

loganrosen
Copy link
Contributor

Which problem is this PR solving?

The repository currently depends on an old version of typescript-eslint (v5).

Short description of the changes

Upgrading to typescript-eslint v8 to pick up the latest recommended lint rules and modifying the code to be compliant with the new rules. In most cases, this required updating/adding new ignores for renamed/new rules. In other cases, non-breaking changes were made to the code to make it compliant. I also upgraded eslint to the last v8 version due to a new stricter peer dependency requirement.

How Has This Been Tested?

npm run lint and npm run test succeed.

@loganrosen loganrosen requested a review from a team as a code owner February 15, 2025 05:00
Copy link

linux-foundation-easycla bot commented Feb 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (56df3c0) to head (fec25b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5478   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         310      310           
  Lines        8008     8013    +5     
  Branches     1616     1620    +4     
=======================================
+ Hits         7611     7616    +5     
  Misses        397      397           
Files with missing lines Coverage Δ
api/src/diag/ComponentLogger.ts 95.00% <100.00%> (ø)
api/src/propagation/TextMapPropagator.ts 14.28% <ø> (ø)
api/src/trace/NoopTracer.ts 97.67% <100.00%> (+0.23%) ⬆️
...ntelemetry-instrumentation-grpc/src/serverUtils.ts 90.54% <ø> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 91.22% <ø> (ø)
...r-base/src/bounded-queue-export-promise-handler.ts 100.00% <100.00%> (ø)
...-base/src/configuration/otlp-http-configuration.ts 100.00% <ø> (ø)
...rter-base/src/transport/http-exporter-transport.ts 94.44% <ø> (ø)
...-grpc-exporter-base/src/grpc-exporter-transport.ts 100.00% <ø> (ø)
...kages/opentelemetry-core/src/utils/lodash.merge.ts 60.86% <ø> (ø)
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented May 5, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 5, 2025
@pichlermarc pichlermarc removed the stale label May 15, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for updating this @loganrosen 🙌

Could you please add a changelog since some of the types have changed in DiagConsoleLogger from any to unknown in @opentelemetry/api. In practice, this change should not make any difference for anyone, but I'd want to make sure it's called out in the changelog (api/CHANGELOG.md) as a feature, so that it does not get unintentionally released as a bugfix). 🙂

Other than that, this PR looks good 🙂

@loganrosen loganrosen requested a review from pichlermarc May 31, 2025 21:55
@pichlermarc pichlermarc added this pull request to the merge queue Jun 4, 2025
Merged via the queue into open-telemetry:main with commit 3578f68 Jun 4, 2025
25 checks passed
@opentelemetrybot
Copy link
Contributor

Thank you for your contribution @loganrosen! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants