Skip to content

feat(instrumentation-pg): update to stable semantic conventions #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jun 10, 2025

Which problem is this PR solving?

Short description of the changes

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (5909ad4) to head (9cf4d66).

Files with missing lines Patch % Lines
...node/opentelemetry-instrumentation-pg/src/utils.ts 88.46% 3 Missing ⚠️
...elemetry-instrumentation-pg/src/instrumentation.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   89.53%   89.76%   +0.23%     
==========================================
  Files         182      187       +5     
  Lines        8837     9176     +339     
  Branches     1844     1894      +50     
==========================================
+ Hits         7912     8237     +325     
- Misses        925      939      +14     
Files with missing lines Coverage Δ
...telemetry-instrumentation-pg/src/internal-types.ts 100.00% <ø> (ø)
...de/opentelemetry-instrumentation-pg/src/semconv.ts 100.00% <100.00%> (ø)
...elemetry-instrumentation-pg/src/instrumentation.ts 94.68% <80.00%> (-0.37%) ⬇️
...node/opentelemetry-instrumentation-pg/src/utils.ts 95.75% <88.46%> (-1.56%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing: It would be helpful, I think, to add a "Semantic Conventions" section to the instr-pg README, perhaps modelled after https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/README.md#semantic-conventions

@maryliag maryliag marked this pull request as ready for review June 13, 2025 19:58
@maryliag maryliag requested a review from a team as a code owner June 13, 2025 19:58
@maryliag
Copy link
Contributor Author

maryliag commented Jun 13, 2025

Still todo: add semantic conv section on README
Update tests

@maryliag
Copy link
Contributor Author

@trentm ready for review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants