-
Notifications
You must be signed in to change notification settings - Fork 580
feat(instrumentation-pg): update to stable semantic conventions #2881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2881 +/- ##
==========================================
+ Coverage 89.53% 89.76% +0.23%
==========================================
Files 182 187 +5
Lines 8837 9176 +339
Branches 1844 1894 +50
==========================================
+ Hits 7912 8237 +325
- Misses 925 939 +14
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing: It would be helpful, I think, to add a "Semantic Conventions" section to the instr-pg README, perhaps modelled after https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/README.md#semantic-conventions
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…trib into update-sem-pg
Still todo: add semantic conv section on README |
@trentm ready for review 😄 |
Which problem is this PR solving?
Short description of the changes
OTEL_SEMCONV_STABILITY_OPT_IN
to decide when to send OLD, STABLE or BOTH (see https://opentelemetry.io/docs/specs/semconv/non-normative/db-migration/)