-
Notifications
You must be signed in to change notification settings - Fork 580
chore: add new PR workflow #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: add new PR workflow #2866
Conversation
…a/opentelemetry-js-contrib into dluna-ci-pr-speed-and-coverage
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
- name: Install | ||
run: npm ci | ||
- name: Download Build Artifacts | ||
# TODO: add the rest of versions (18.19.0 & 20.6.0)? or are these enough?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if easy to do we could also use these for completeness, but just using 18 and 20 is likely more than okay 🙂
@@ -34,7 +35,7 @@ jobs: | |||
if-no-files-found: error | |||
retention-days: 1 | |||
|
|||
unit-test: | |||
unit-and-tav-test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping the name unit-test
would help with repo settings, since unit-test (18) and unit-test (18.19.0) required checks. Repo managment is now automated from another repo, so changing the check's name would require us to open a PR in that other repo before merging this (which would then block other PRs from getting merged)
If we want to change the name we can do so in a smaller follow-up PR. :)
Which problem is this PR solving?
Changes the PR workflow to a single file to improve it making it faster with less resource consumption. The goal is to provide feedback to the PR author by compiling, testing and reporting coverage only for the affected packages in the PR (as for now it does a compilation, test, and coverage report for all in nodejs v18). More details on the plan can be found in #2870
Closes: #2870
Short description of the changes
*:ci:affected
script at root to execute tasks only for affected packages (leveragingnx
CLI)codecov.yml
to assign flags to each package so reports can be updated independentlyChecklist
Codecov flags feature require a first manual upload to create them so it would be helpful to resume #2214 to at least have a script at the root to testa and upload all reports. There is also some PRs that affect the flag configuration so it would be preferable to have them merged 1st
test:with-services
script at the root