-
Notifications
You must be signed in to change notification settings - Fork 580
chore: upgrade lerna #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade lerna #2836
Changes from all commits
590d035
5d268b5
221fc4f
ae4ed34
f38a38c
4e229dc
fb4df28
9f37712
6b8d618
362fb4f
6d8aaa1
629f866
174d218
23b7c71
60400f0
67723d6
8972f4b
05020c1
0726e0c
a60d5f4
3887b70
eae2663
6f48e5b
1df01ae
d86b1f2
ddf5b7f
5e90af5
6ee4863
577d584
c048ccd
947a253
a544ed3
2433805
9d5e7e4
96684c1
534ed2a
8dd6c23
d48f9f9
1eadc59
b138e0d
b1829bf
a2ae0f1
6e58cbf
fee8a85
3a6b1dc
1678af4
022d36f
057e093
8900a76
449fd3c
302f079
1de18b2
da0ce71
5d90ebc
a8f31d4
3d3c1f8
e45533c
b5c182e
e1c5799
8af5873
dc2ec97
1b0560f
1a6f774
645054b
f26493b
1773343
d8d8a71
5525f8a
2e5b5ea
d76522c
f655a20
e49d69c
3ebc8fb
a0f5696
8a79c9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,8 @@ jobs: | |
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Install lerna | ||
run: npm install -g lerna@6.6.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note to reviewer: the script |
||
- name: Install glob | ||
run: npm install glob | ||
|
||
- name: Ensure Release Please Config and Manifest are in sync with the repository | ||
run: node scripts/check-release-please.mjs |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,7 +69,7 @@ docs | |
|
||
#lerna | ||
.changelog | ||
package.json.lerna_backup | ||
.nx | ||
|
||
# OS generated files | ||
.DS_Store | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,6 @@ Decide on the next `major.minor.patch` release number based on [semver](http://s | |
|
||
- Use `npm install` command to initialize all package directories | ||
- Use `lerna publish --skip-npm --no-git-tag-version --no-push` to bump the version in all `package.json` | ||
- Use `npm run bootstrap` to generate latest `version.ts` files | ||
|
||
## Use the Changelog to create a GitHub Release | ||
|
||
|
@@ -90,18 +89,16 @@ Create a pull request titled `chore: x.y.z release proposal`. The commit body sh | |
|
||
Merge the PR, and pull the changes locally (using the commands in the first step). Ensure that `chore: x.y.z release proposal` is the most recent commit. | ||
|
||
## Publish all packages | ||
## Compile all packages | ||
|
||
Go into each directory and use `npm publish` (requires permissions) to publish the package. You can use the following script to automate this. | ||
Go into the root folder and run `npm ci && npm run compile` to build all packages with the latest version of the code. | ||
|
||
```bash | ||
#!/bin/bash | ||
## Publish all packages | ||
|
||
Use lerna's `publish` command to walk over all non private packages and publish the ones that has not been published yet. | ||
|
||
for dir in $(ls packages); do | ||
pushd packages/$dir | ||
npm publish | ||
popd | ||
done | ||
```sh | ||
npx lerna publish from-package --no-push --no-private --no-git-tag-version --no-verify-access --yes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note to reviewer: is this section used? I've updated but I think now all the releases are done via CI right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the whole (In the 2.5 years I've been a maintainer, I've never needed to do a manual release in the contrib repo 🙂) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From the top of this file:
Given this gets out of date, it would possibly be better to drop it. I'd defer to @pichlermarc for an opinion on that as he does most of the releasing. Update: Marc already gave an opinion on this above (#2836 (comment)). |
||
``` | ||
|
||
Check your e-mail and make sure the number of “you’ve published this module” emails matches the number you expect. | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: there is no need to have
lerna
orchestrating this task since the script could iterate over the package folders that need API check