Skip to content

refactor(examples): update semconv usage to ATTR_ exports #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

trentm
Copy link
Contributor

@trentm trentm commented May 9, 2025

Refs: #2377

Note: I did not work through the steps for each example. Clearly many of these examples are out of date and need work. However, there is no way this change will add more breakage, examples/**/package.json include "@opentelemetry/semantic-conventions": "^1.27.0", and version 1.27.0 has the ATTR_SERVICE_NAME export being used.

@trentm trentm self-assigned this May 9, 2025
@trentm trentm requested a review from a team as a code owner May 9, 2025 21:29
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (e0d2cb2) to head (80efa02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2819      +/-   ##
==========================================
- Coverage   89.67%   89.37%   -0.31%     
==========================================
  Files         184      179       -5     
  Lines        8946     8636     -310     
  Branches     1834     1794      -40     
==========================================
- Hits         8022     7718     -304     
+ Misses        924      918       -6     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. We have a start at describing the updates needed for examples but haven't come back around to it yet. This is still a good change

@trentm trentm enabled auto-merge (squash) May 12, 2025 17:12
@trentm trentm merged commit ddf9bd5 into open-telemetry:main May 12, 2025
4 checks passed
@trentm trentm deleted the trentm-semconv-up-examples branch May 12, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants