-
Notifications
You must be signed in to change notification settings - Fork 580
feat(instrumentation-aws-sdk): add gen ai metrics for bedrock #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plugins/node/opentelemetry-instrumentation-aws-sdk/test/load-instrumentation.ts
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2771 +/- ##
==========================================
+ Coverage 89.67% 89.69% +0.02%
==========================================
Files 184 184
Lines 8946 8966 +20
Branches 1834 1835 +1
==========================================
+ Hits 8022 8042 +20
Misses 924 924
🚀 New features to boost your workflow:
|
plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/bedrock-runtime.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/bedrock-runtime.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-aws-sdk/test/load-instrumentation.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-aws-sdk/test/lambda.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-aws-sdk/test/load-instrumentation.ts
Outdated
Show resolved
Hide resolved
…y-js-contrib into bedrock-metrics
Thanks @trentm applied the cleanups. Apologies for the delay finally back to work from kubecon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins/node/opentelemetry-instrumentation-aws-sdk/src/aws-sdk.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/bedrock-runtime.ts
Outdated
Show resolved
Hide resolved
Thanks - updated semconv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trentm The metrics support in ServiceExtension
looks good, no concern from me.
plugins/node/opentelemetry-instrumentation-aws-sdk/src/aws-sdk.ts
Outdated
Show resolved
Hide resolved
LGTM! There is a conflict with main branch right now, most likely due to another Bedrock related PR that got merged from #2777, but I think there should be little to resolve. |
…y-js-contrib into bedrock-metrics
42628e1
to
8001341
Compare
Sorry for the delay @jj22ee, resolved the conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's another conflict, but it must likely be package-lock.json
.
…y-js-contrib into bedrock-metrics
…y-js-contrib into bedrock-metrics
Which problem is this PR solving?
Short description of the changes
/cc @trentm @codefromthecrypt