-
Notifications
You must be signed in to change notification settings - Fork 582
test(aws-sdk): remove runs for Node.js <18.x #2763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
==========================================
+ Coverage 90.49% 90.51% +0.01%
==========================================
Files 166 166
Lines 8020 8020
Branches 1533 1533
==========================================
+ Hits 7258 7259 +1
+ Misses 762 761 -1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, please keep the skip-test-if.js
script around though. we'll likely need it for other instrumentations soon.
This reverts commit 9c21f06.
This change was done in #2700 (comment) |
Which problem is this PR solving?
Short description of the changes