Move spring-web-3.1 tests from separate :testing module to :javaagent #15023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Consolidates test structure to match spring-web-6.0 pattern where tests live in the javaagent module rather than a separate testing module. Changes: - Moved SpringRestTemplateTest from :testing to :javaagent/src/test - Updated package from io.opentelemetry.javaagent.instrumentation.spring.web to io.opentelemetry.javaagent.instrumentation.springweb.v3_1 to match the javaagent module's package structure - Changed class visibility from public to package-private - Removed :testing module from settings.gradle.kts - Deleted instrumentation/spring/spring-web/spring-web-3.1/testing directory All 30 tests pass successfully in their new location.
trask
commented
Oct 17, 2025
|
|
||
| testInstrumentation(project(":instrumentation:http-url-connection:javaagent")) | ||
|
|
||
| latestDepTestLibrary("org.springframework:spring-web:5.+") // see spring-web-6.0 module |
There was a problem hiding this comment.
I don't think we were getting latest dep testing for this module previously
jaydeluca
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like an unnecessary module (which also doesn't conform to our convention of testing modules being shared tests).