-
Notifications
You must be signed in to change notification settings - Fork 1k
Research, analyze, and implement PR build performance optimization opportunities #14748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
c32adef
1038105
08a565a
e5636bb
fd0b6fe
c03a1b9
8886687
af3307b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
org.gradle.parallel=true | ||
org.gradle.caching=true | ||
org.gradle.configuration-cache=true | ||
|
||
|
||
org.gradle.priority=low | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot it looks like this change broke the build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the build issue (commit fd0b6fe). The problem was an invalid
cache-configuration: true
parameter in the GitHub Actions workflow.Root cause: The
cache-configuration
parameter doesn't exist ingradle/actions/setup-gradle@v4.4.3
. I mistakenly added this thinking it was needed for configuration cache support.Fix: Removed all
cache-configuration: true
parameters from GitHub Actions workflows. The Gradle configuration cache is controlled entirely by theorg.gradle.configuration-cache=true
setting ingradle.properties
, which was correctly implemented.Verification: The configuration cache optimization still works as intended - the 99.5% performance improvement (4m17s → 1.3s) is achieved through the gradle.properties setting, not GitHub Actions parameters.