Skip to content

Conversation

AlchemyDing
Copy link
Member

resolve issue

@AlchemyDing AlchemyDing requested a review from a team as a code owner August 31, 2025 05:27
@SylvainJuge
Copy link
Contributor

As described in the related issue #14502 this is a breaking change, so changing the default behavior should only be applied in 3.0.

I think you should thus split this in two steps:

  • implement the change with an opt-in configuration option, so the default behavior remains the same: what this PR should provide
  • in the next major, toggle the default to this new behavior, remove the configuration option and the now "legacy" behavior. Opening a dedicated issue and adding it the 3.0 milestone so we don't forget about this is recommended.

Here is an example of similar issues/PRs to deal with semconv breaking changes:

@AlchemyDing
Copy link
Member Author

As described in the related issue #14502 this is a breaking change, so changing the default behavior should only be applied in 3.0.

I think you should thus split this in two steps:

  • implement the change with an opt-in configuration option, so the default behavior remains the same: what this PR should provide
  • in the next major, toggle the default to this new behavior, remove the configuration option and the now "legacy" behavior. Opening a dedicated issue and adding it the 3.0 milestone so we don't forget about this is recommended.

Here is an example of similar issues/PRs to deal with semconv breaking changes:

@SylvainJuge Thank you for your suggestion. I will make this PR as STEP 1

@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@AlchemyDing AlchemyDing marked this pull request as draft September 2, 2025 02:10
@AlchemyDing AlchemyDing marked this pull request as ready for review September 2, 2025 16:13
@breedx-splk breedx-splk added this to the v3.0.0 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove messaging header normalization

3 participants