-
Notifications
You must be signed in to change notification settings - Fork 1k
Intercept metrics in test runner #13891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mentation into metric-interceptor
…mentation into metric-interceptor
|
||
# Remove all .telemetry directories recursively from the project root | ||
echo "Searching for and removing all .telemetry directories..." | ||
find . -type d -name ".telemetry" -exec rm -rf {} + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trask - from your question during the SIG meeting:
The {} bit is the placeholder for the exec command. Whatever files are found by find are inserted in place of the brackets. The + means to build up a long list of the found files and call the exec on all of them at once instead of one at a time, like the more traditional -exec {} ; variant.
hs_err_pid* | ||
replay_pid* | ||
.attach_pid* | ||
**/.telemetry* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**/.telemetry* | |
.telemetry/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should work
if you only want to ignore it in the root, it would be different:
/.telemetry/
Now we're getting to the fun part...
This PR covers a few changes:
otel.nullaway-conventions
plugin (as recommended here) and addressed all issues raised by it.telemetry
files within each instrumentation module directoryI wanted to keep this PR small-ish, so I didn't go through and start enabling this for other modules, but I will followup with that.
I am also going to play around with how we might handle situations where different metrics are emitted by different config options (like
-Dotel.semconv-stability.opt-in=database
, as an example), and how we might best display that informationRelated to #13468