Skip to content

ClickHouse JDBC URL support #13884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

ClickHouse JDBC URL support #13884

merged 4 commits into from
May 21, 2025

Conversation

john9x
Copy link
Contributor

@john9x john9x commented May 20, 2025

Resolves #13883

@john9x john9x requested a review from a team as a code owner May 20, 2025 14:47
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 20, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label May 20, 2025
@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

laurit
laurit reviewed May 21, 2025
View reviewed changes
...rc/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java
@Override
public Stream<? extends Arguments> provideArguments(ExtensionContext context) {
return args(
// https://clickhouse.com/docs/integrations/language-clients/java/jdbc#configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://clickhouse.com/docs/integrations/language-clients/java/jdbc#configuration mentions that besides clickhouse ch could also be used. Should jdbc:ch://localhost:8123 also be handled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the driver code ch used as alias for clickhouse but Connection metadata always return full prefix jdbc:clickhouse:
https://github.com/ClickHouse/clickhouse-java/blob/main/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseConnectionImpl.java#L1141

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment about this to the parsing logic to make clear that ch doesn't need to be handled

@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@laurit laurit merged commit fd9949d into open-telemetry:main May 21, 2025
86 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees

No one assigned

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ClickHouse JDBC URL support

3 participants

@john9x @laurit @jaydeluca