feat: support instrumentation for jsonrpc4j #13008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
4 times, most recently
from
55628cf to
b605e52
Compare
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
from
b605e52 to
0190c13
Compare
|
Hello @trask , could you please take a look when you have time? I'm also working on the testing. |
adam-awx
reviewed
Jan 8, 2025
...etry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonServiceExporterBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
adam-awx
reviewed
Jan 8, 2025
adam-awx
reviewed
Jan 8, 2025
adam-awx
reviewed
Jan 8, 2025
...ntelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcServerBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
adam-awx
reviewed
Jan 8, 2025
...ntelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcClientBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
adam-awx
reviewed
Jan 8, 2025
...ntelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcClientBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
adam-awx
reviewed
Jan 8, 2025
steverao
reviewed
Jan 8, 2025
...ntelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcClientBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 8, 2025
steverao
reviewed
Jan 8, 2025
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
from
ee68060 to
6f50140
Compare
steverao
reviewed
Jan 8, 2025
steverao
reviewed
Jan 8, 2025
.../io/opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/JsonRpcServerInstrumentation.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 8, 2025
...rc/test/java/io/opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_6/AgentJsonRpcTest.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 8, 2025
There was a problem hiding this comment.
You forget to add related information in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/supported-libraries.md#libraries--frameworks
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
from
861450e to
974c315
Compare
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
5 times, most recently
from
d6fc515 to
8644438
Compare
|
Hi @steverao I updated the code, could you take another look ? |
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
from
8644438 to
06f0869
Compare
laurit
reviewed
Jan 21, 2025
.../io/opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_3/JsonRpcClientInstrumentation.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/javaagent/instrumentation/jsonrpc4j/v1_3/JsonRpcClientInstrumentation.java
Outdated
Show resolved
Hide resolved
...sting/src/main/java/io/opentelemetry/instrumentation/jsonrpc4j/v1_3/AbstractJsonRpcTest.java
Outdated
Show resolved
Hide resolved
| "{\"jsonrpc\":\"2.0\",\"method\":\"add\",\"params\":[1,2],\"id\":1}" | ||
| .getBytes(UTF_8)); | ||
| ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); | ||
| server.handleRequest(inputStream, outputStream); |
There was a problem hiding this comment.
this test does not verify that context is propagated, perhaps should use a real http request?
.../io/opentelemetry/instrumentation/jsonrpc4j/v1_3/OpenTelemetryJsonRpcInvocationListener.java
Outdated
Show resolved
Hide resolved
|
@laurit Thank you for the review, I resolved some comments, will work on the remaining ones tomorrow |
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
from
145e58d to
c92c0ef
Compare
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
4 times, most recently
from
f781d8c to
b40f27d
Compare
chenlujjj
force-pushed
the
feat/jsonrpc-instrumentation
branch
from
b40f27d to
7972e68
Compare
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
|
@chenlujjj we have recently kicked off an RPC semantic convention stability SIG and it would be interesting to us if you wanted to pursue this PR (cc @lmolkova) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve: #6020
The instrumentation is for both server and client:
JsonRpcServer'sinvocationListeneras an instance ofOpenTelemetryJsonRpcInvocationListenerinvokemethod of bothJsonRpcHttpClientandJsonRpcRestClientI'm new to this repository, so I borrowed the implementation of grpc and http client instrumentation