[Hangfire] Fix flaky test

[martincostello]

Changes

• Avoid InvalidOperationException by copying collection before passing to Any().
• Refactor while loop to improve readability.

Have also created this PR to avoid the problem in the library the tests use: perrich/Hangfire.MemoryStorage#47

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[Copilot]

Pull Request Overview

This PR fixes a flaky test by avoiding an InvalidOperationException through copying the job history collection, and refactors the wait loop for better readability.

• Replace DateTime timeout check with a CancellationTokenSource based on a TimeSpan
• Extract a local Completed() function that copies the job history to avoid modification exceptions

Comments suppressed due to low confidence (2)

test/OpenTelemetry.Instrumentation.Hangfire.Tests/HangfireInstrumentationJobFilterAttributeTests.cs:185

• [nitpick] Consider renaming the local function 'Completed' to 'IsJobCompleted' to more clearly indicate that it returns a boolean value assessing job completion.

bool Completed()

test/OpenTelemetry.Instrumentation.Hangfire.Tests/HangfireInstrumentationJobFilterAttributeTests.cs:182

• Consider passing the cancellation token to Task.Delay (e.g., Task.Delay(500, cts.Token)) to allow the loop to exit promptly when the token is cancelled.

await Task.Delay(500);

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (71655ce) to head (801077e).
Report is 875 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2835       +/-   ##
===========================================
+ Coverage   73.91%   93.58%   +19.67%     
===========================================
  Files         267        4      -263     
  Lines        9615       78     -9537     
===========================================
- Hits         7107       73     -7034     
+ Misses       2508        5     -2503     

Flag	Coverage Δ
unittests-Instrumentation.Hangfire	93.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 261 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TimothyMothra]

LGTM