Add minimum token permissions for all github workflow files #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Jul 2, 2025
Merged
via the queue into
open-telemetry:main
with commit Jul 2, 2025
0b07764
32 of 33 checks passed
|
|
||
|
|
||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
Doesn't this completely break the indentation?
There was a problem hiding this comment.
Yeah this looks completely wrong 🙈
songy23
added a commit
to songy23/opentelemetry-collector-releases
that referenced
this pull request
Jul 2, 2025
…pen-telemetry#990)" This reverts commit 0b07764.
trask
pushed a commit
to trask/opentelemetry-collector-releases
that referenced
this pull request
Jul 7, 2025
…emetry#990) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2025
* Add minimum token permissions for all github workflow files (#990) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Remove the bad ones * add token permissions to regression test pipeline * remove whitespace * remove whitespace * remove whitespace * remove whitespace * remove whitespace * fix double permission yaml fields --------- Co-authored-by: OpenTelemetry Bot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
mowies
added a commit
to mowies/opentelemetry-collector-releases
that referenced
this pull request
Jul 28, 2025
* Add minimum token permissions for all github workflow files (open-telemetry#990) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Remove the bad ones * add token permissions to regression test pipeline * remove whitespace * remove whitespace * remove whitespace * remove whitespace * remove whitespace * fix double permission yaml fields --------- Co-authored-by: OpenTelemetry Bot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See open-telemetry/sig-security#148 for details.
Please check this PR carefully and watch out for any permission-related workflow failures after merging it.
cc @trask