Skip to content

Conversation

cyberkov
Copy link
Contributor

@cyberkov cyberkov commented Oct 3, 2025

I hope this Fixes #1197
Unfortunately I am not able to test this change locally (except for the make build, which doesn't seem to produce the msi).

@cyberkov cyberkov requested a review from a team as a code owner October 3, 2025 11:46
@cyberkov cyberkov requested a review from TylerHelmuth October 3, 2025 11:46
Copy link

linux-foundation-easycla bot commented Oct 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cyberkov / name: Hannes Schaller (be9c93b)
  • ✅ login: mowies / name: Moritz Wiesinger (4ae20b6)

@mowies mowies requested a review from pjanotti October 6, 2025 06:24
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cyberkov! Code changes LGTM, but we need a corresponding .chloggen/ file for the change, let's know if you need pointers for that. After that we should be good to move ahead.

I guess it is a bit hard to test in CI because it will require various steps like creating another user, running as that user, etc. That said you can do a manual validation downloading the MSI with your change from https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/18221357537/artifacts/4189207545

@cyberkov cyberkov force-pushed the msi-allow-upgrades branch from 4d69ffc to be9c93b Compare October 8, 2025 06:31
@cyberkov
Copy link
Contributor Author

cyberkov commented Oct 8, 2025

Hello @pjanotti!

Thank you for the artifact. I successfully verified the in-place upgrade. The changelog file has been added to the PR.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cyberkov!

@pjanotti
Copy link
Contributor

pjanotti commented Oct 8, 2025

Failures in CI - Core - GoReleaser / Package tests / Package Tests (rpm) (pull_request) are unrelated to the present changes.

@mowies mowies added this pull request to the merge queue Oct 9, 2025
Merged via the queue into open-telemetry:main with commit 3ee65db Oct 9, 2025
93 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows MSI does not allow upgrading in place

3 participants