Skip to content

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 22, 2025

@mx-psi
Copy link
Member Author

mx-psi commented Sep 22, 2025

I am not sure the golden tests worked:

Running golden tests...
 golden Pulling 
 f810d8f5b82d Pulling fs layer 
 c978529a5a44 Pulling fs layer 
 f810d8f5b82d Downloading [>                                                  ]  1.378kB/122.7kB
 f810d8f5b82d Downloading [==================================================>]  122.7kB/122.7kB
 f810d8f5b82d Download complete 
 f810d8f5b82d Extracting [=============>                                     ]  32.77kB/122.7kB
 f810d8f5b82d Extracting [==================================================>]  122.7kB/122.7kB
 f810d8f5b82d Pull complete 
 c978529a5a44 Downloading [>                                                  ]  162.6kB/15.77MB
 c978529a5a44 Verifying Checksum 
 c978529a5a44 Download complete 
 c978529a5a44 Extracting [>                                                  ]  163.8kB/15.77MB
 c978529a5a44 Extracting [================================>                  ]  10.16MB/15.77MB
 c978529a5a44 Extracting [==================================================>]  15.77MB/15.77MB
 c978529a5a44 Pull complete 
 golden Pulled 
 Network golden_default  Creating
 Network golden_default  Created
 Container golden  Creating
 Container collector  Creating
 Container collector  Created
 Container golden  Created
 Container collector  Starting
 Container golden  Starting
 Container collector  Started
 Container golden  Started
 Container collector  Waiting
 Container golden  Waiting
 Container collector  Healthy
 Container golden  Healthy
2025-09-22T11:59:19.229Z	DEBUG	Logger core does not support injecting component attributes
2025-09-22T11:59:19.229Z	DEBUG	otlpreceiver@v0.135.1-0.20250918163459-ba0b327d5fe9/otlp.go:58	created signal-agnostic logger
2025-09-22T11:59:19.230Z	INFO	otlpreceiver@v0.135.1-0.20250918163459-ba0b327d5fe9/otlp.go:121	Starting GRPC server	{"endpoint": "[::]:4317"}
2025-09-22T11:59:19.230Z	INFO	otlpreceiver@v0.135.1-0.20250918163459-ba0b327d5fe9/otlp.go:179	Starting HTTP server	{"endpoint": "[::]:4318"}

@atoulme can you help me understand this? Link: https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/17913642544/job/50933474457?pr=1178

@jade-guiton-dd
Copy link
Contributor

It looks like golden doesn't print anything on success, so I think this is expected behavior.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 22, 2025

It looks like golden doesn't print anything on success, so I think this is expected behavior.

Yeah I guess to put more explicitly what my point of confusion was: shouldn't this fail? But I answered my own question by looking at contrib and realizing that open-telemetry/opentelemetry-collector-contrib/pull/42475 already bumped the Prometheus dependency

@songy23
Copy link
Member

songy23 commented Sep 22, 2025

open-telemetry/opentelemetry-collector-contrib#42475 already bumped the Prometheus dependency

That was caught by the replace in this repo so the artifacts are still on v0.58. Now v0.60 fixes it, we don't need to pin to v0.58 any more

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@songy23 songy23 marked this pull request as ready for review September 22, 2025 21:27
@songy23 songy23 requested review from a team as code owners September 22, 2025 21:27
@songy23 songy23 requested a review from edmocosta September 22, 2025 21:27
@songy23 songy23 added this pull request to the merge queue Sep 22, 2025
Merged via the queue into open-telemetry:main with commit c9b8fd3 Sep 22, 2025
111 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants