-
Notifications
You must be signed in to change notification settings - Fork 213
[distributions] Stop pinning Prometheus Go SDK dependency #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[distributions] Stop pinning Prometheus Go SDK dependency #1178
Conversation
I am not sure the golden tests worked:
@atoulme can you help me understand this? Link: https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/17913642544/job/50933474457?pr=1178 |
It looks like |
Yeah I guess to put more explicitly what my point of confusion was: shouldn't this fail? But I answered my own question by looking at contrib and realizing that open-telemetry/opentelemetry-collector-contrib/pull/42475 already bumped the Prometheus dependency |
That was caught by the replace in this repo so the artifacts are still on v0.58. Now v0.60 fixes it, we don't need to pin to v0.58 any more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
c9b8fd3
After open-telemetry/opentelemetry-collector-contrib/pull/42493 I think we are ready for this!
Fixes #1068
Fixes open-telemetry/opentelemetry-collector/issues/12939