packaging: Start producing container images for Windows 2025

[olljanat]

Continuation for #872 to also provide container images for Windows Server 2025

[mowies]

please add a changelog entry by copying the .chloggen/TEMPLATE.yaml file and filling it out

[olljanat]

please add a changelog entry by copying the .chloggen/TEMPLATE.yaml file and filling it out

Ah, it needs to be copied. Was just confused as there it no any other files on that folder but I see now that release process removes those.

Anyway, I see at least contrib collector crashing in start when build for Win 2025 because it depends on some DLLs which does not exists in that version of nanoserver image anymore so converted to draft for now.

[douglascamata]

Anyway, I see at least contrib collector crashing in start when build for Win 2025 because it depends on some DLLs which does not exists in that version of nanoserver image anymore so converted to draft for now.

@olljanat do you happen to know if such DLL will ever be included in the win 2025 nanoserver image? Asking because if it won't, I think it's fine for us to use a "bigger" base image for win 2025 so that we can support this version of Windows.

[olljanat]

I would guess that no. Normally Microsoft just remove components from nanoserver but let’s wait that open-telemetry/opentelemetry-collector-contrib#42297 is merged before evaluation of “bigger” image.

[pjanotti]

Anyway, I see at least contrib collector crashing in start when build for Win 2025 because it depends on some DLLs which does not exists in that version of nanoserver image anymore so converted to draft for now.

@olljanat can you share the exact error message that you are getting?

[pjanotti]

Change itself LGTM - I'm just want to understand the error mentioned about a missing DLL.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[pjanotti]

Ping @olljanat - do you plan to get back to this one?

[olljanat]

I'm just want to understand the error mentioned about a missing DLL.

Sorry about delay. Error is:

panic: Failed to find PdhOpenQuery procedure in pdh.dll: The specified procedure could not be found.

goroutine 1 [running]:
syscall.(*DLL).MustFindProc(...)
        syscall/dll_windows.go:127
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters/internal/third_party/telegraf/win_perf_counters.init.1()
        github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters@v0.136.0/internal/third_party/telegraf/win_perf_counters/pdh.go:199 +0x411

do you happen to know if such DLL will ever be included in the win 2025 nanoserver image? Asking because if it won't, I think it's fine for us to use a "bigger" base image for win 2025 so that we can support this version of Windows.

Yes using mcr.microsoft.com/windows/servercore:ltsc2025-amd64 as base image fixes that DLL error so I think that it is needed.

do you plan to get back to this one?

Not sure what it right place handle that exception?

[pjanotti]

Thanks for the details @olljanat - at first PdhOpenQuery is in the list of supported APIs per this doc. 🤔 I'm going to look into this ...

[pjanotti]

The attempt to find the proc PdhOpenQuery comes from pkg/winperfcounters/internal/third_party/telegraf/win_perf_counters/pdh.go since various other succeeded before this one failing I think we should attempt to fix this by fixing the package code.

[pjanotti]

Just confirmed from the 2025 nano image:

          1    0 00001B60 PdhAddCounterW
          2    1 00001C70 PdhAddEnglishCounterW
          3    2 00001D80 PdhCalculateCounterFromRawValue
          4    3 00001EA0 PdhCloseLog
          5    4 00001FA0 PdhCloseQuery
          6    5 00002190 PdhCollectQueryData
          7    6 00002090 PdhCollectQueryDataEx
          8    7 00002280 PdhEnumObjectItemsW
          9    8 000023F0 PdhEnumObjectsW
         10    9 00002510 PdhExpandCounterPathW
         11    A 00002610 PdhExpandWildCardPathW
         12    B 00002730 PdhGetCounterInfoW
         13    C 00002840 PdhGetFormattedCounterArrayW
         14    D 00002960 PdhGetFormattedCounterValue
         15    E 00002A70 PdhGetRawCounterValue
         16    F 00002B70 PdhOpenLogW
         17   10 000031F0 PdhOpenQueryH
         18   11 00002CB0 PdhOpenQueryW
         19   12 00002DB0 PdhRemoveCounter
         20   13 00002EA0 PdhUpdateLogW
         21   14 00002FB0 PdhValidatePathW

so there is no PdhOpenQuery we have to use PdhOpenQueryW directly instead of relying on the extra symbol available on the pdh.dll shipped on the other Windows images.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[douglascamata]

Hey @olljanat, let us know if you still plan to work on this so that we remove the stale label in this case. Thank you!

[olljanat]

Closed for now as migration to PdhOpenQueryW mentioned above needs to be done first.