[chore] verify new docker token #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowies
approved these changes
Jul 7, 2025
dmathieu
approved these changes
Jul 7, 2025
|
I verified the token in 1password works, so I copied that back over into the github org secret |
|
seems to still have the same issue of incorrect username/password :( |
trask
commented
Jul 7, 2025
| - name: Log into Docker.io using new token | ||
| uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0 | ||
| with: | ||
| username: ${{ secrets.DOCKER_USERNAME }} |
There was a problem hiding this comment.
just realized this repo has its own DOCKER_USERNAME secret, while at the org level it's defined as a variable
Suggested change
| username: ${{ secrets.DOCKER_USERNAME }} | |
| username: ${{ vars.DOCKER_USERNAME }} |
|
sorry folks, this is the first repo we've migrated from old token, so I didn't think about it that it was probably previously using someone's individual username/password and not the |
mowies
pushed a commit
to mowies/opentelemetry-collector-releases
that referenced
this pull request
Jul 15, 2025
* Verify new token * Update .github/workflows/regression-tests.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/community#2805
cc @jade-guiton-dd @mowies