[processor/filter] Add filter action identifier #43774
Open
+834
−315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Action determines the behavior when Conditions match.
- "drop" (default): logs matching any condition are dropped.
- "keep": logs matching any condition are kept, all others are dropped.
Example config
```
filter:
error_mode: propagate
logs:
action: "drop"
log_record:
- 'attributes["some"] == "values"'
```
kaisecheng
requested review from
a team,
TylerHelmuth,
edmocosta and
evan-bradley
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit added an "action" option to Logs, Metrics, Traces and Profiles to specify whether the given conditions are identifying what is kept or dropped.
Example config
If
actionis not specified,dropwill be used.Link to tracking issue
Fixes #42321
Testing
Added unit tests for the modified methods and functions
Documentation
Added docs for "action" to README.md