[pkg/stanza] Fix collector stops reading new file after copytruncate rotation #43758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rotation Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…ector-contrib into fix/43693 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
andrzej-stencel
requested changes
Oct 24, 2025
There was a problem hiding this comment.
I'm marking this as "Request changes", because I want to be sure we understand the consequences before merging this.
In principle, the fingerprint is the identifier of a file. The biggest issue I see here is that this seems to dismiss this principle in some cases.
I'll examine this pull request and your comments @paulojmdias on the corresponding issue in more detail. Thank you for digging into this! 🙏
|
Sure @andrzej-stencel! Please let me know of you need something. Thanks for your review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the log lines are written exactly with the first
1000bytes equal, if acopytruncatehappens, is there a possibility of stopping reading the file. This was discovered using theotlpjsonfilereceiver and doing thecopytruncateoption on multiple services.This PR resets the offsets if the current offset is higher than the file size, which usually happens when a
copytruncateoperation occurs.Link to tracking issue
Fixes #43693
Testing
Added tests to simulate writing the same lines more than 1000 bytes multiple times, and validate
copytruncateoffsets reset.