[pkg/ottl] Support dynamic pattern key in keep_keys and keep_matching_keys functions #43729
+152
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_keys functions Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
requested review from
a team,
TylerHelmuth,
edmocosta and
evan-bradley
as code owners
Comment on lines
+41
to
+48
| keySet := make(map[string]struct{}, len(keys)) | ||
| for _, key := range keys { | ||
| k, err := key.Get(ctx, tCtx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| keySet[k] = struct{}{} | ||
| } |
There was a problem hiding this comment.
We should check if the getter is a literal so that we can avoid making a new map on each pass if we don't need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking issue
Part of #43555