Skip to content

[processor/metricstarttime] a new starttimeattribute strategy and additional configs: skip_if_ct_exists and filters #43694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[processor/metricstarttime] a new starttimeattribute strategy and additional configs: skip_if_ct_exists and filters #43694

wants to merge 6 commits into from

Conversation

@eriksywu
Copy link

@eriksywu eriksywu commented Oct 21, 2025 •
edited
Loading

Description

See: #43739

  • a new start_time_attribute strategy that works in a similar fashion to start_time_metric but will use the resource’s pod start time or last transition time to the ContainersReady condition
  • a skip_if_ct_exists config oaramter: if true, the processor shall not do adjustments if the metric already has ST set - allowing fallback strategies to be chained
  • a include_metrics and exclude_metrics config parameter: filters on the metric name to apply the processor on

Link to tracking issue

Fixes

Testing

Documentation

@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Oct 21, 2025
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@eriksywu
initial poc for starttimeattribute strategy
33a942d
@eriksywu
[processor/metricstarttime]:
db3e852 
- add new `starttimeattribute` strategy to use pod start time (or pod containersready time) as ST
- allow all strategies to only apply to filtered metrics
- allow all strategies to skip metrics with CTs already set
@eriksywu
linters
dc63c2b
@eriksywu
changelog
239ee74
@eriksywu eriksywu force-pushed the erw/metricstarttime_k8s_attrs branch from a1e8eb0 to 239ee74 Compare October 22, 2025 19:55
@eriksywu eriksywu changed the title initial poc for starttimeattribute strategy [processor/metricstarttime] a new starttimeattribute strategy and additional configs: skip_if_ct_exists and filters Oct 22, 2025
@eriksywu eriksywu mentioned this pull request Oct 22, 2025
Open
@eriksywu eriksywu marked this pull request as ready for review October 22, 2025 20:33
@eriksywu eriksywu requested review from a team and dashpole as code owners October 22, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@ridwanmsharif ridwanmsharif Awaiting requested review from ridwanmsharif

At least 1 approving review is required to merge this pull request.

Assignees

@crobert-1 crobert-1

Labels

first-time contributor PRs made by new contributors processor/metricstarttime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eriksywu @crobert-1