-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[chore] Move Datadog E2E tests and examples #43629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Move Datadog E2E tests and examples #43629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mackjmr I recall you're updating our docs to point the examples to their new locations?
Let's make sure this PR does not break things again if ^ already happens...
|
Oops, yeah we should coordinate. My opinion is that Update: Looks like some of the links have already been updated, so I'll update them back in a follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming you have the PR to update datadog/documentation
Description
#42805 moved Datadog's E2E tests into
internal/e2e, and the example configurations used as part of the tests intointernal/e2e/examples. The intent was to move the tests intointernal/datadog/e2einstead, but it looks like this change was accidentally reverted during a force push. Moreover, it seems that moving the example configs created some broken links (eg. here, "collector.yaml", here, "example configuration").This PR:
internal/e2etointernal/datadog/e2e