Skip to content

Conversation

@jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Oct 17, 2025

Description

#42805 moved Datadog's E2E tests into internal/e2e, and the example configurations used as part of the tests into internal/e2e/examples. The intent was to move the tests into internal/datadog/e2e instead, but it looks like this change was accidentally reverted during a force push. Moreover, it seems that moving the example configs created some broken links (eg. here, "collector.yaml", here, "example configuration").

This PR:

  • moves internal/e2e to internal/datadog/e2e
  • moves the example configs back to their original location to restore these links

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mackjmr I recall you're updating our docs to point the examples to their new locations?

Let's make sure this PR does not break things again if ^ already happens...

@jade-guiton-dd
Copy link
Contributor Author

jade-guiton-dd commented Oct 23, 2025

Oops, yeah we should coordinate.

My opinion is that internal/e2e/examples isn't a good location for discoverability, or for labelling those examples as Datadog-specific, so I think they need to move regardless. Moving them back to their original location under the exporter is the simplest since it doesn't require updating the links, but I could move them to something like pkg/datadog if you think that makes more sense.

Update: Looks like some of the links have already been updated, so I'll update them back in a follow up PR.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming you have the PR to update datadog/documentation

@atoulme atoulme merged commit 45ee5ed into open-telemetry:main Oct 24, 2025
190 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants