-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(receiver): add redfish implementation #43612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
@atoulme Hey Antoine, here is the 2nd PR from the contrib docs instructions. This includes a concrete implementation of the redfish receiver. I did notice some receivers have metrics enabled by default and some don't. I see the value in this as you can make receivers more backwards compatible by adding new metrics as disabled to allow users to iterate on new metrics. I've set them as enabled by default, please let me know if this is okay. |
@steven-freed given the naming of the metrics (ie not redfish specific), did you consider following the sem conv definition for hardware as a number of them would already be covered and it would encourage interoperability. The main gap that I see is a metric for indicating if the hardware is enabled/disabled but that could be addressed. I agree that the sem conv metrics could be improved/refined with the best feedback coming from implementing/using them. |
@thompson-tomo Oh I didn't know about this. This looks great! I will look into it more. Thanks! |
Maybe tmi but I am going on a 2 week vacation soon and not sure if I have the time to refactor this before I leave. I will try to though! |
This PR LGTM, please fix the conflict. We can merge this as it is and have a second PR to adopt semconv. |
Signed-off-by: Steve Freed <freedgitr@gmail.com>
Signed-off-by: Steve Freed <freedgitr@gmail.com>
@atoulme should be good to go now. The one failure appears to be failing on the main branch as well. |
Description
Adds redfish receiver implementation. This initial implementation includes metrics for the following redfish resources and can be expanded upon in the future as there are many redfish resources; ComputerSystem, Chassis, Fans, Temperatures.
Link to tracking issue
#33724
Testing
Tested with data from HPE DL20 gen10, HPE DL20 gen11, and Dell PowerEdge machines.
Documentation
New metrics docs were added.