[pkg/ottl] Add support for non maps elements to SliceToMap #43521
+184
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealAnna
requested review from
a team,
TylerHelmuth,
edmocosta and
evan-bradley
as code owners
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
RealAnna
force-pushed
the
feat/nonmaps-elements-to-slicetomap
branch
from
bc159a3 to
5dd8558
Compare
RealAnna
force-pushed
the
feat/nonmaps-elements-to-slicetomap
branch
from
5dd8558 to
1261caf
Compare
|
@edmocosta could you please allow the workflow on this PR? Thank you! |
edmocosta
reviewed
Oct 15, 2025
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
RealAnna
force-pushed
the
feat/nonmaps-elements-to-slicetomap
branch
from
0f75296 to
1fb115b
Compare
RealAnna
commented
Oct 17, 2025
edmocosta
reviewed
Oct 17, 2025
| elem := v.At(i) | ||
|
|
||
| // If key_path is not set, key is the index | ||
| key := strconv.Itoa(i) |
There was a problem hiding this comment.
Let's only execute strconv.Itoa(i) if necessary and save some cycles on critical/busy paths, we can move this assignment down to the if useKeyPath condition.
| } | ||
| extractedValue, err := extractValue(e, valuePath.Get()) | ||
|
|
||
| err := putValue(value, m, key) |
There was a problem hiding this comment.
The putValue function is probably not needed, we can replace it by:
value.CopyTo(m.PutEmpty(key))
RealAnna
commented
Oct 20, 2025
RealAnna
commented
Oct 21, 2025
Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports non Map elements
Link to tracking issue
Fixes #43099
Testing
added a few corresponding table tests