-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[receiver/k8seventsreceiver] Add more types to severity map #43402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gaddas3
wants to merge
24
commits into
open-telemetry:main
Choose a base branch
from
gaddas3:k8seventsreceiver-update-severity-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−15
Open
Changes from 5 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7d04c7c
Add more types to severity map
gaddas3 53896bf
Reference to k8s event api
gaddas3 a9c8224
Merge branch 'open-telemetry:main' into k8seventsreceiver-update-seve…
gaddas3 01e2177
Merge branch 'open-telemetry:main' into k8seventsreceiver-update-seve…
gaddas3 a5471bb
Merge branch 'open-telemetry:main' into k8seventsreceiver-update-seve…
gaddas3 90fb6a6
keep the existing severity mapping logic
gaddas3 15cf372
keep the existing severity mapping logic
gaddas3 68ec4b1
update change log for receiver/k8seventsreceiver
gaddas3 9cb9cbb
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 81fc37e
keep the existing severity mapping logic
gaddas3 b1cbcd4
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 9219e58
update change log for receiver/k8seventsreceiver
gaddas3 ea8aa34
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 df2b233
update change log
gaddas3 29d3680
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 690ec12
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 91738ff
unit tests for different event types
gaddas3 dfe79e8
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 8385208
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 059bcda
unit tests for different event types
gaddas3 85f8e1b
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 087f33f
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 b5c909e
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 ab2e762
Merge branch 'main' into k8seventsreceiver-update-severity-map
gaddas3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason you're not just adding the new types here? I do agree that this implementation is preserving some more info but I'm not sure it s needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate on this. Are referring to adding other types https://github.com/open-telemetry/opentelemetry-collector/blob/main/pdata/plog/severity_number.go#L14-L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a bad use of words on my part. I meant just adding them there, without the rest of the logic (which is the state of the PR now)