Skip to content

Code Ownership for AWSCloudWatchLogsExporter (yaten2302) #43039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 2, 2025
Merged

Code Ownership for AWSCloudWatchLogsExporter (yaten2302) #43039

merged 12 commits into from
Oct 2, 2025

Conversation

@yaten2302
Copy link
Contributor

Description

This PR is for adding a yaten2302 as a code owner for the AWSCloudWatchLogsExporter component.

@yaten2302
add yaten2302 as AWSCloudWatchLogsExporter code-owner
a067a63 
Signed-off-by: Yaten <yaten598@gmail.com>
@yaten2302 yaten2302 requested a review from a team as a code owner September 29, 2025 08:01
@yaten2302 yaten2302 requested a review from codeboten September 29, 2025 08:01
@github-actions github-actions bot added the exporter/awscloudwatchlogs awscloudwatchlogs exporter label Sep 29, 2025
songy23
songy23 reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/component_labels.txt is out of date, please run "make genlabels" and commit the changes in this PR.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 29, 2025
@songy23
Copy link
Member

songy23 commented Sep 30, 2025

Generated code is out of date, please run "make gencodeowners" or apply this diff and commit the changes in this PR.

@yaten2302
Copy link
Contributor Author

@songy23 , after running - make gencodeowners, the AWSCloudWatchLogsExporter component has been added into the unmaintained components list?
Did I do something wrong 👀

@yaten2302
run - make genlabels
99f74c4 
Signed-off-by: Yaten <yaten598@gmail.com>
songy23
songy23 reviewed Oct 1, 2025
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to move it from unmaintained to alpha

@yaten2302 @songy23
Update exporter/awscloudwatchlogsexporter/metadata.yaml
1623d90 
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@songy23
Copy link
Member

songy23 commented Oct 1, 2025

now need to run make generate and make gencodeowners again and we should be good to go

@dmitryax
Copy link
Member

dmitryax commented Oct 1, 2025

Still failing. I think make checks should handle all the generated stuff

@songy23
Copy link
Member

songy23 commented Oct 1, 2025

...and make genlabels too

You may also want to add a changelog that AWSCloudWatchLogsExporter is no longer unmaintained, but totally up to you

@songy23 songy23 removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 2, 2025
songy23
songy23 reviewed Oct 2, 2025
View reviewed changes
@songy23 songy23 merged commit 9076436 into open-telemetry:main Oct 2, 2025
185 of 186 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 2, 2025
@yaten2302 yaten2302 deleted the codeownership-yaten2302-AWSCloudWatchLogsExporter branch October 4, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryax dmitryax dmitryax approved these changes

@songy23 songy23 songy23 approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@mwear mwear

Labels

exporter/awscloudwatchlogs awscloudwatchlogs exporter

Projects

None yet

Milestone

v0.137.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yaten2302 @songy23 @dmitryax @mwear