[exporter/prometheus] Fix namespace build error logging when namespace is not configured #43034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added changelog entry for the bug fix in `prometheusexporter` - Updated `newCollector` to handle empty namespace configuration
NassimBtk
requested review from
a team,
ArthurSens and
dashpole
as code owners
…fig.Namespace-is-not-set
- Extracted namespace normalization logic into `normalizeNamespace` function - Added unit tests for empty, invalid, and sanitized namespaces
- Updated `TestNormalizeNamespaceEmpty` to use `require.Empty` - Updated `TestNormalizeNamespaceInvalid` to use `require.Empty`
…fig.Namespace-is-not-set
constanca-m
approved these changes
Sep 29, 2025
dashpole
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheusexporternewCollectorto handle empty namespace configurationDescription
This pull request addresses an issue in the
prometheusexporterwhere an error was logged if the namespace was not configured, even though this is a valid configuration scenario. The changes ensure that the exporter only attempts to build and log errors for the namespace if it is explicitly specified, improving error handling and reducing unnecessary log noise.Bug Fixes and Error Handling
exporter/prometheusexporter/collector.goso that the namespace is only built and error-checked ifconfig.Namespaceis set, preventing misleading error logs when the namespace is intentionally omitted.Documentation and Release Notes
.chloggen/prometheus-skip-namespace-build-if-missing.yamlto document the bug fix in RN.Link to tracking issue
Fixes #43015