-
Notifications
You must be signed in to change notification settings - Fork 3.1k
impl log partition by trace id #43029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl log partition by trace id #43029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR @OhJuhun!
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @OhJuhun. Looks good, just a few more minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this @OhJuhun, looks great! Please fix the CI failures and then it's good to go :)
|
@axw thank you for your help and review! |
|
Thank you for your contribution @OhJuhun! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
|
/easycla |
### Description Added log partitioning capability to the Kafka Exporter. When the `partition_logs_by_trace_id` option is enabled, log records are distributed to Kafka partitions based on their TraceID. Records without a TraceID fall back to the default partitioning strategy. If `partition_logs_by_resource_attributes` is also enabled, resource attribute partitioning takes precedence over TraceID partitioning. ### Link to tracking issue Fixes open-telemetry#39146 ### Testing - Added unit tests to validate TraceID-based log partitioning and option precedence logic. - Verified correct partitioning for various combinations of TraceIDs and resource attributes. ### Documentation - Updated `exporter/kafkaexporter/README.md` with usage details and examples for `partition_logs_by_trace_id`. - Included related changelog updates. --------- Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
Description
Added log partitioning capability to the Kafka Exporter. When the
partition_logs_by_trace_idoption is enabled, log records are distributed to Kafka partitions based on their TraceID. Records without a TraceID fall back to the default partitioning strategy. Ifpartition_logs_by_resource_attributesis also enabled, resource attribute partitioning takes precedence over TraceID partitioning.Link to tracking issue
Fixes #39146
Testing
Documentation
exporter/kafkaexporter/README.mdwith usage details and examples forpartition_logs_by_trace_id.