[receiver/kafkametricsreceiver] Add support for using franz-go client under a feature gate #43019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… under a feature gate Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
paulojmdias
requested review from
a team,
MovieStoreGuy,
axw and
dmitryax
as code owners
atoulme
added a commit
that referenced
this pull request
Sep 28, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Seems the CI for `scoped-tests-matrix (windows-latest)` is failing due
to the `Build gotestsum on Windows` error.
```sh
Run make "$(${PWD} -replace '\\', '/')/.tools/gotestsum"
make: *** No rule to make target 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum'. Stop.
Error: Process completed with exit code 1.
```
See
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18048822328/job/51369899669?pr=43018
and
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18050658515/job/51371803867?pr=43019
I think we can simplify the `Build gotestsum` task into a single one
using the `working-directory` definition, and this should fix the issue.
Found the issue in:
-
#43018
-
#43019
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Co-authored-by: Antoine Toulme <atoulme@splunk.com>
atoulme
added a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Sep 28, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Seems the CI for `scoped-tests-matrix (windows-latest)` is failing due
to the `Build gotestsum on Windows` error.
```sh
Run make "$(${PWD} -replace '\\', '/')/.tools/gotestsum"
make: *** No rule to make target 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum'. Stop.
Error: Process completed with exit code 1.
```
See
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18048822328/job/51369899669?pr=43018
and
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18050658515/job/51371803867?pr=43019
I think we can simplify the `Build gotestsum` task into a single one
using the `working-directory` definition, and this should fix the issue.
Found the issue in:
-
open-telemetry#43018
-
open-telemetry#43019
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Co-authored-by: Antoine Toulme <atoulme@splunk.com>
atoulme
added a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Sep 28, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Seems the CI for `scoped-tests-matrix (windows-latest)` is failing due
to the `Build gotestsum on Windows` error.
```sh
Run make "$(${PWD} -replace '\\', '/')/.tools/gotestsum"
make: *** No rule to make target 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum'. Stop.
Error: Process completed with exit code 1.
```
See
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18048822328/job/51369899669?pr=43018
and
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18050658515/job/51371803867?pr=43019
I think we can simplify the `Build gotestsum` task into a single one
using the `working-directory` definition, and this should fix the issue.
Found the issue in:
-
open-telemetry#43018
-
open-telemetry#43019
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
dmitryax
approved these changes
Oct 5, 2025
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2025
… under a feature gate (open-telemetry#43019) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds franz-go support to the kafkametricsreceiver, behind a feature gate (`receiver.kafkametricsreceiver.UseFranzGo`). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41480 <!--Describe what testing was performed and which tests were added.--> #### Testing Tested locally and added tests for trying to cover all the current Sarama ones. <!--Describe the documentation added.--> #### Documentation Updated README.md with reference about opt-in using franz-go library. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
axw
added a commit
to axw/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
… under a feature gate (open-telemetry#43019) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds franz-go support to the kafkametricsreceiver, behind a feature gate (`receiver.kafkametricsreceiver.UseFranzGo`). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41480 <!--Describe what testing was performed and which tests were added.--> #### Testing Tested locally and added tests for trying to cover all the current Sarama ones. <!--Describe the documentation added.--> #### Documentation Updated README.md with reference about opt-in using franz-go library. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
songy23
pushed a commit
that referenced
this pull request
Oct 10, 2025
#### Description I would like to propose adding @paulojmdias as a code owner of the Kafka components. He has been doing excellent work across all of those components (and more besides!). - #42507 - #42796 - #43105 - #42181 - #42327 - #42507 - #42796 - #43019 - #43083 - #43105 #### Link to tracking issue N/A #### Testing N/A #### Documentation N/A
ChrsMark
pushed a commit
to ChrsMark/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2025
#### Description I would like to propose adding @paulojmdias as a code owner of the Kafka components. He has been doing excellent work across all of those components (and more besides!). - open-telemetry#42507 - open-telemetry#42796 - open-telemetry#43105 - open-telemetry#42181 - open-telemetry#42327 - open-telemetry#42507 - open-telemetry#42796 - open-telemetry#43019 - open-telemetry#43083 - open-telemetry#43105 #### Link to tracking issue N/A #### Testing N/A #### Documentation N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds franz-go support to the kafkametricsreceiver, behind a feature gate (
receiver.kafkametricsreceiver.UseFranzGo).Link to tracking issue
Fixes #41480
Testing
Tested locally and added tests for trying to cover all the current Sarama ones.
Documentation
Updated README.md with reference about opt-in using franz-go library.