-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(deps): update module github.com/prometheus/otlptranslator to v1 #42876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/prometheus/otlptranslator to v1 #42876
Conversation
|
looking at this now |
|
I can't figure out what's failing so I can't really fix this |
|
I found: |
|
would love to know how you tracked that down! I couldn't even find a readable log entry in the CI |
|
As a followup to this update, which for some users is a breaking change for metric names, I am creating this PR which exposes options necessary to restore the old (now deprecated) behavior: #43050 |
|
hmmm, there will need to be more work done to prevent bad experiences for users upgrading to this version. We may want to roll this back util we've added the config options necessary |
|
@ywwg could you raise the PR reverting it? |
|
Based on our discussion, this upgrade does need to stay here first so that the options can be added. So no revert |
|
The problem is that we are not confident that just the upgrade won't break anybody, and discussions need to happen to understand how to integrate the new otlptranslator code with the existing feature gate 😬 I'm still voting to revert this PR, and we'll do the bump together with the changes needed to make the feature gate work |
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
v0.0.2->v1.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
prometheus/otlptranslator (github.com/prometheus/otlptranslator)
v1.0.0Compare Source
_) character are no longer prefixed with the wordkeyduring translation. Folks who depend on such behavior can re-enable it by settingLabelNamer.UnderscoreLabelSanitization = true. #55LabelNamer.PreserveMultipleUnderscores = true. Be aware that ifUTF8Allowedis set to true, multiple underscores are preserved even ifPreserveMultipleUnderscores == false. #58Bug fixes
Performance
Full Changelog: prometheus/otlptranslator@v0.0.2...v1.0.0
Configuration
📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.