-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add splunk.license.expiration.seconds_remaining Metric for splunkenterprisereceiver #42631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add splunk.license.expiration.seconds_remaining Metric for splunkenterprisereceiver #42631
Conversation
f28b8ca to
aa649ef
Compare
|
Mind hitting this with a changelog? |
|
After looking at this PR can we make it more clear in the naming or description of the metric that this is counting down the seconds until the DATE the license expires? Perhaps noting that this is specifically for time period licensing. Versus the possible confusion of this metric being a "rolling" calculation of license usage (i.e. Ingest pricing) and when it would expire based on varying ingest patterns? maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a tiny note in the metadata about what instance the metric comes from this lgtm! 🖖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution and for making these requested changes!! LGTM!
🖖
|
Thank you for your contribution @macolby42! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
…rprisereceiver (open-telemetry#42631) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a new metric to splunkenterprisereceiver called `splunk.license.expiration.seconds_remaining` with three attributes, `splunk.license.status`, `splunk.license.label`, and `splunk.license.type`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#42630 <!--Describe what testing was performed and which tests were added.--> #### Testing Tested on a Splunk stack, and retrieved metrics in Splunk O11y. <!--Describe the documentation added.--> #### Documentation Added the standard documentation that outlines the metric and its attributes. <!--Please delete paragraphs that you did not use before submitting.-->
…rprisereceiver (open-telemetry#42631) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a new metric to splunkenterprisereceiver called `splunk.license.expiration.seconds_remaining` with three attributes, `splunk.license.status`, `splunk.license.label`, and `splunk.license.type`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#42630 <!--Describe what testing was performed and which tests were added.--> #### Testing Tested on a Splunk stack, and retrieved metrics in Splunk O11y. <!--Describe the documentation added.--> #### Documentation Added the standard documentation that outlines the metric and its attributes. <!--Please delete paragraphs that you did not use before submitting.-->
Description
This PR adds a new metric to splunkenterprisereceiver called
splunk.license.expiration.seconds_remainingwith three attributes,splunk.license.status,splunk.license.label, andsplunk.license.type.Link to tracking issue
Fixes #42630
Testing
Tested on a Splunk stack, and retrieved metrics in Splunk O11y.
Documentation
Added the standard documentation that outlines the metric and its attributes.