Skip to content

Conversation

@macolby42
Copy link
Contributor

@macolby42 macolby42 commented Sep 10, 2025

Description

This PR adds a new metric to splunkenterprisereceiver called splunk.license.expiration.seconds_remaining with three attributes, splunk.license.status, splunk.license.label, and splunk.license.type.

Link to tracking issue

Fixes #42630

Testing

Tested on a Splunk stack, and retrieved metrics in Splunk O11y.

Documentation

Added the standard documentation that outlines the metric and its attributes.

@macolby42 macolby42 force-pushed the splunkenterprisereceiver_license_timeleft branch from f28b8ca to aa649ef Compare September 11, 2025 18:33
@greatestusername
Copy link
Contributor

Mind hitting this with a changelog?

@greatestusername
Copy link
Contributor

greatestusername commented Sep 16, 2025

After looking at this PR can we make it more clear in the naming or description of the metric that this is counting down the seconds until the DATE the license expires? Perhaps noting that this is specifically for time period licensing.

Versus the possible confusion of this metric being a "rolling" calculation of license usage (i.e. Ingest pricing) and when it would expire based on varying ingest patterns?

maybe splunk.license.seconds.until.expiration or something? I ask as this caught me up at first and could catch other's

Copy link
Contributor

@greatestusername greatestusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a tiny note in the metadata about what instance the metric comes from this lgtm! 🖖

Copy link
Contributor

@greatestusername greatestusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and for making these requested changes!! LGTM!

🖖

@macolby42 macolby42 changed the title Add splunk.time.remaining Metric for splunkenterprisereceiver Add splunk.license.expiration.seconds_remaining Metric for splunkenterprisereceiver Sep 30, 2025
@atoulme atoulme merged commit d05e40f into open-telemetry:main Oct 7, 2025
186 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 7, 2025
@otelbot
Copy link
Contributor

otelbot bot commented Oct 7, 2025

Thank you for your contribution @macolby42! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

mashhurs pushed a commit to mashhurs/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2025
…rprisereceiver (open-telemetry#42631)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a new metric to splunkenterprisereceiver called
`splunk.license.expiration.seconds_remaining` with three attributes,
`splunk.license.status`, `splunk.license.label`, and
`splunk.license.type`.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#42630 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Tested on a Splunk stack, and retrieved metrics in Splunk O11y.

<!--Describe the documentation added.-->
#### Documentation
Added the standard documentation that outlines the metric and its
attributes.

<!--Please delete paragraphs that you did not use before submitting.-->
tommyers-elastic pushed a commit to tommyers-elastic/opentelemetry-collector-contrib that referenced this pull request Oct 10, 2025
…rprisereceiver (open-telemetry#42631)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a new metric to splunkenterprisereceiver called
`splunk.license.expiration.seconds_remaining` with three attributes,
`splunk.license.status`, `splunk.license.label`, and
`splunk.license.type`.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#42630 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Tested on a Splunk stack, and retrieved metrics in Splunk O11y.

<!--Describe the documentation added.-->
#### Documentation
Added the standard documentation that outlines the metric and its
attributes.

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Metric for Splunk License Time Remaining

5 participants