Skip to content

Conversation

@yvrhdn
Copy link
Contributor

@yvrhdn yvrhdn commented Sep 1, 2025

Description

This is a follow-up task from #41819: deprecate the sampled attribute on metrics which have decision.

Queries using sampled can be updated:

  • sampled="true" ➡️ decision="sampled"
  • sampled="false" ➡️ either decision!="sampled" or decision=~"not_sampled|dropped"

This impacts the following metrics

otelcol_processor_tail_sampling_count_traces_sampled
otelcol_processor_tail_sampling_count_spans_sampled
otelcol_processor_tail_sampling_global_count_traces_sampled

This does not impact

otelcol_processor_tail_sampling_early_releases_from_cache_decision

Since this metric doesn't have decision. (When we make a sampling decision based upon the cache, we don't have enough context to fill in the decision).

@yvrhdn yvrhdn requested a review from a team as a code owner September 1, 2025 15:41
@yvrhdn yvrhdn requested a review from fatsheep9146 September 1, 2025 15:41
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Sep 1, 2025
@yvrhdn
Copy link
Contributor Author

yvrhdn commented Sep 8, 2025

@atoulme can you take a look again please? I got a review from the code owner so I believe this PR is good to go 🙂

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@yvrhdn
Copy link
Contributor Author

yvrhdn commented Sep 29, 2025

This PR is not stale! It should be all good to get merged

@github-actions github-actions bot removed the Stale label Sep 30, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants