Skip to content

Conversation

@kyo-ke
Copy link

@kyo-ke kyo-ke commented Aug 16, 2025

Description

First version of metricsaslogs connector.
this connector connect metric pipeline to log pipeline
what it do is
create LogRecord per DataPoint

attributes are mapped to

Metric Resource -> Log Resource
Metric Scope -> Log Scope
datapoint -> logrecord

Link to tracking issue

Fixes #40938

Testing

unit test with over 90% coverage

Documentation

@kyo-ke kyo-ke requested a review from a team as a code owner August 16, 2025 08:35
@kyo-ke kyo-ke requested a review from atoulme August 16, 2025 08:35
@kyo-ke
Copy link
Author

kyo-ke commented Aug 16, 2025

unit test output

$ go test -cover
{"level":"warn","msg":"Unknown metric type","type":"Empty"}
PASS
coverage: 99.2% of statements
ok github.com/open-telemetry/opentelemetry-collector-contrib/connector/metricsaslogsconnector 0.507s

@aarvee11
Copy link
Contributor

aarvee11 commented Aug 16, 2025

@kyo-ke : Kindly visit the Contributing Guidelines found at CONTRIBUTING.md

To make things faster, find the quick fixes below, but I insist you to kindly go through the link above for a smooth process

Steps to fix all the failing checks:

  1. build-and-test / check-collector-module-version (pull_request) - patch the /connector/metricsaslogsconnector/go.mod file as per the runner output from lines 94 to 143
  2. build-and-test / checks (pull_request) - Run make goporto from the root of the repo and stage the changes
  3. build-and-test / lint (pull_request) - Will auto resolve when all checks have passed
  4. build-and-test / lint-matrix (linux, connector) (pull_request) - License generation has failed. Run make addlicense from the root of the repo and stage the changes
  5. build-and-test / lint-matrix (windows, connector) (pull_request) - same as point#4 above
  6. changelog / changelog (pull_request) - Changelog missing. Check the Chnagelog generation steps
  7. codeowners / check-codeowners (pull_request_target) - Mention only the sponsor's github ID here. If you have not found one, follow the steps from link
  8. scoped-test / scoped-tests (pull_request) - Same as Point#4

After fixing all the above, make a push to the same branch of your fork, and allow all the above checks to PASS

Cheers...

Copy link
Contributor

@aarvee11 aarvee11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly make the necessary changes, follow the steps in my comment above and also the contributing guidelienes

@kyo-ke
Copy link
Author

kyo-ke commented Aug 17, 2025

@aarvee11 Thank you for he review.
I updated the PR.

@kyo-ke kyo-ke changed the title feat: first version of metricsaslogs connector [connector/metricsaslogsconnector] first version of metricsaslogs connector Aug 17, 2025
@aarvee11
Copy link
Contributor

@kyo-ke Please resolve the comments above that are open for the CI to kick in and finish the tests

@kyo-ke
Copy link
Author

kyo-ke commented Aug 19, 2025

sure
all comments are resolved

@atoulme atoulme added the Accepted Component New component has been sponsored label Aug 20, 2025
@atoulme
Copy link
Contributor

atoulme commented Aug 20, 2025

Update to latest main, then run make genotelcontribcol'. Then run ./.github/workflows/scripts/check-collector-module-version.shandmake tidylist` and push your changes.

@kyo-ke
Copy link
Author

kyo-ke commented Aug 20, 2025

@atoulme Thank you for review!
PR updated

@atoulme
Copy link
Contributor

atoulme commented Sep 2, 2025

Please run make gencodecov

@kyo-ke
Copy link
Author

kyo-ke commented Sep 2, 2025

Please run make gencodecov

Updated.
Thank you for the review!

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 17, 2025
@kyo-ke
Copy link
Author

kyo-ke commented Sep 17, 2025

@atoulme
should I update versions.yaml to pass the check?

@github-actions github-actions bot removed the Stale label Sep 18, 2025
@atoulme
Copy link
Contributor

atoulme commented Sep 26, 2025

@atoulme should I update versions.yaml to pass the check?

CI says:

verifyAllModulesInSet failed: Module github.com/open-telemetry/opentelemetry-collector-contrib/connector/metricsaslogsconnector (defined in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/metricsaslogsconnector/go.mod) is not listed in any module set.

Please add it to the list.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 19, 2025
@kyo-ke
Copy link
Author

kyo-ke commented Oct 19, 2025

hello @atoulme
versions updated.
could you re-run the test ?

@github-actions github-actions bot removed the Stale label Oct 20, 2025
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Oct 24, 2025
@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Oct 24, 2025
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted Component New component has been sponsored first-time contributor PRs made by new contributors ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New component: Open telemetry collector connector metrics to logs

4 participants