[processor/resourcedetection] support openstack nova into resourcedetection processor #41973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection processor Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
3 tasks
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
github-actions
bot
added
processor/resourcedetection
atoulme
reviewed
Aug 14, 2025
processor/resourcedetectionprocessor/internal/openstack/nova/metadata.yaml
Show resolved
Hide resolved
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
|
@paulojmdias would you like to become the codeowner of this code path? We will need your expertise to maintain this code. |
|
@atoulme sure yes 🙏 I appreciate the invite and I really want to continue helping the community 🙌 |
I am pinging you on the CNCF slack with instructions. |
6 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/label never-stale -stale |
…-contrib into feat/39117 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…-contrib into feat/39117 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
|
I added myself as a code owner, together with the parent codeowners of |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/label -stale never-stale |
…-contrib into feat/39117 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
dashpole
reviewed
Sep 29, 2025
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
dashpole
approved these changes
Sep 29, 2025
atoulme
added
the
ready to merge
mashhurs
pushed a commit
to mashhurs/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…ection processor (open-telemetry#41973) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR introduces a new resource detection processor for OpenStack Nova, similar to the existing AWS EC2 and GCP GCE detectors. It uses the Nova instance metadata service to populate standard `cloud.*` and `host.*` attributes, and optionally captures selected meta labels as resource attributes based on user-defined regex filters. Despite the current semantic convention discussion in open-telemetry/semantic-conventions#2622, I made this PR ready for review for the code and discussed improvements. So when this PR was marked ready for review, the following values were set hardcoded temporarily. ```go d.rb.SetCloudProvider("openstack") d.rb.SetCloudPlatform("openstack_nova") ``` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39117 <!--Describe what testing was performed and which tests were added.--> #### Testing I tested against OpenStack instances, and the output was the expected. ```sh Resource attributes: -> host.type: Str(REDACTED) -> cloud.provider: Str(openstack) -> cloud.platform: Str(openstack_nova) -> cloud.account.id: Str(REDACTED) -> cloud.availability_zone: Str(REDACTED) -> host.id: Str(680a44a7-a2f1-40bc-9b19-6f6ad9592290) -> host.name: Str(instance01) -> openstack.nova.meta.key1: Str(value1) -> openstack.nova.meta.key2: Str(value2) ``` I also added tests to cover all the cases. If I'm missing something, please let me know. <!--Describe the documentation added.--> #### Documentation Added documentation for how to enable the detection for `nova` and also the docs generated with `mdatagen`. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Paulo Dias <paulodias.gm@gmail.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
…ection processor (open-telemetry#41973) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR introduces a new resource detection processor for OpenStack Nova, similar to the existing AWS EC2 and GCP GCE detectors. It uses the Nova instance metadata service to populate standard `cloud.*` and `host.*` attributes, and optionally captures selected meta labels as resource attributes based on user-defined regex filters. Despite the current semantic convention discussion in open-telemetry/semantic-conventions#2622, I made this PR ready for review for the code and discussed improvements. So when this PR was marked ready for review, the following values were set hardcoded temporarily. ```go d.rb.SetCloudProvider("openstack") d.rb.SetCloudPlatform("openstack_nova") ``` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39117 <!--Describe what testing was performed and which tests were added.--> #### Testing I tested against OpenStack instances, and the output was the expected. ```sh Resource attributes: -> host.type: Str(REDACTED) -> cloud.provider: Str(openstack) -> cloud.platform: Str(openstack_nova) -> cloud.account.id: Str(REDACTED) -> cloud.availability_zone: Str(REDACTED) -> host.id: Str(680a44a7-a2f1-40bc-9b19-6f6ad9592290) -> host.name: Str(instance01) -> openstack.nova.meta.key1: Str(value1) -> openstack.nova.meta.key2: Str(value2) ``` I also added tests to cover all the cases. If I'm missing something, please let me know. <!--Describe the documentation added.--> #### Documentation Added documentation for how to enable the detection for `nova` and also the docs generated with `mdatagen`. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Paulo Dias <paulodias.gm@gmail.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new resource detection processor for OpenStack Nova, similar to the existing AWS EC2 and GCP GCE detectors.
It uses the Nova instance metadata service to populate standard
cloud.*andhost.*attributes, and optionally captures selected meta labels as resource attributes based on user-defined regex filters.Despite the current semantic convention discussion in open-telemetry/semantic-conventions#2622, I made this PR ready for review for the code and discussed improvements. So when this PR was marked ready for review, the following values were set hardcoded temporarily.
Link to tracking issue
Fixes #39117
Testing
I tested against OpenStack instances, and the output was the expected.
Resource attributes: -> host.type: Str(REDACTED) -> cloud.provider: Str(openstack) -> cloud.platform: Str(openstack_nova) -> cloud.account.id: Str(REDACTED) -> cloud.availability_zone: Str(REDACTED) -> host.id: Str(680a44a7-a2f1-40bc-9b19-6f6ad9592290) -> host.name: Str(instance01) -> openstack.nova.meta.key1: Str(value1) -> openstack.nova.meta.key2: Str(value2)I also added tests to cover all the cases. If I'm missing something, please let me know.
Documentation
Added documentation for how to enable the detection for
novaand also the docs generated withmdatagen.