[connector/count] attribute can be found from scope and resource attributes #41859
+230
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frapschen
force-pushed
the
enhance-countconnector
branch
6 times, most recently
from
e6ea68d to
c8140d8
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Frapschen
force-pushed
the
enhance-countconnector
branch
from
c8140d8 to
96f6aa2
Compare
Frapschen
force-pushed
the
enhance-countconnector
branch
from
96f6aa2 to
de8c452
Compare
Frapschen
force-pushed
the
enhance-countconnector
branch
from
de8c452 to
3ad4f78
Compare
Frapschen
force-pushed
the
enhance-countconnector
branch
2 times, most recently
from
3b5d81c to
db52587
Compare
|
@akats7 please review as codeowner |
Frapschen
force-pushed
the
enhance-countconnector
branch
from
db52587 to
a47a3dc
Compare
|
A friendly ping @akats7, please review this enhancement. |
Frapschen
force-pushed
the
enhance-countconnector
branch
from
a47a3dc to
b6707f7
Compare
|
Sorry for the delay, will review this by EOD |
akats7
reviewed
Sep 30, 2025
akats7
approved these changes
Sep 30, 2025
Frapschen
force-pushed
the
enhance-countconnector
branch
from
709388c to
ac32041
Compare
akats7
reviewed
Sep 30, 2025
| component: countconnector | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: attribute can be found from scope and resource attributes |
There was a problem hiding this comment.
I do think this chlog could be made a bit more clear/descriptive for what is being added for the release notes
There was a problem hiding this comment.
@akats7 Updated, please review.
atoulme
approved these changes
Oct 8, 2025
|
@Frapschen please address the comment and resolve the conflict. |
Frapschen
force-pushed
the
enhance-countconnector
branch
2 times, most recently
from
aa36957 to
ba87786
Compare
|
@akats7 one more review please |
Frapschen
force-pushed
the
enhance-countconnector
branch
from
ba87786 to
87570eb
Compare
akats7
approved these changes
Oct 22, 2025
Frapschen
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current count connector can only set attributes from span, log record, or similar sources. This PR enhances that functionality.
With this update, the count connector will set attributes in the following precedence order: