-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[receiver/azureeventhub] Implements support to ingest app metrics #41367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[receiver/azureeventhub] Implements support to ingest app metrics #41367
Conversation
|
@olofmontin-truesec Is there some documentation about how these AppMetrics are structured? In my original work it wasn't something that I was consuming. I think it would be good to expand the README to include information related to how these type of values are handled versus typical Resource Metrics. |
@cparkins, good question! I peeked into the event hubs messages and used that data. It follows the documentation partly, as the data contains some of the fields specified. The documentation I found was
When thinking about it, I didn't check if there was a go implemented SDK with the model. Did some brief searching and couldn't find any. Yes, I'm happy to extend the README |
|
I'll be off on vacation next week, and thereby no activity here until the 28th of August. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
7f427a8 to
3c15f22
Compare
3c15f22 to
b832e31
Compare
b832e31 to
6abf4ee
Compare
|
@atoulme How can we get the workflows approved? |
|
I have to explicitly approve each run. |
That's a lot of workloads to approve 😅 |
|
I see there's some issues with missing changelog and license. I'll fix those. And I can also add some test data. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
4733bb6 to
ede41db
Compare
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
@olofmontin-truesec please address the CI and mark ready for review again |
ede41db to
2fa4eca
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Running CI again. |
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Description
Link to tracking issue
Fixes #41343
Testing
Tests added for the parsing of both resource and app metrics.
Maybe not of value for you, but tested in my development environment in Azure, receiving metrics from remote tenants and exporting to a managed prometheus data collection rule using the Prometheus remote writer exporter.
Documentation
I'm happy to extend the documentation if this code and feature is of any interest