Skip to content

Conversation

@olofmontin-truesec
Copy link

Description

  • Extends the metrics unmarshaler with support for parsing metrics with type "AppMetrics" forwarded from Application Insights
  • Moves the appending of attributes into each record, as if there could be records from multiple resources within the same payload
  • Implements an optional average aggregator, configured in the component config

Link to tracking issue

Fixes #41343

Testing

Tests added for the parsing of both resource and app metrics.

Maybe not of value for you, but tested in my development environment in Azure, receiving metrics from remote tenants and exporting to a managed prometheus data collection rule using the Prometheus remote writer exporter.

Documentation

I'm happy to extend the documentation if this code and feature is of any interest

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: atoulme / name: Antoine Toulme (71cc7d5)
  • ✅ login: olofmontin-truesec / name: Olof Montin (242eac7)

@cparkins
Copy link
Contributor

@olofmontin-truesec Is there some documentation about how these AppMetrics are structured? In my original work it wasn't something that I was consuming. I think it would be good to expand the README to include information related to how these type of values are handled versus typical Resource Metrics.

@olofmontin-truesec
Copy link
Author

@olofmontin-truesec Is there some documentation about how these AppMetrics are structured? In my original work it wasn't something that I was consuming. I think it would be good to expand the README to include information related to how these type of values are handled versus typical Resource Metrics.

@cparkins, good question! I peeked into the event hubs messages and used that data. It follows the documentation partly, as the data contains some of the fields specified.

The documentation I found was

When thinking about it, I didn't check if there was a go implemented SDK with the model. Did some brief searching and couldn't find any.

Yes, I'm happy to extend the README

@olofmontin-truesec
Copy link
Author

I'll be off on vacation next week, and thereby no activity here until the 28th of August.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 2, 2025
@olofmontin-truesec olofmontin-truesec force-pushed the feature/azureeventhub-appmetrics branch from 7f427a8 to 3c15f22 Compare August 4, 2025 12:45
@github-actions github-actions bot removed the Stale label Aug 5, 2025
@olofmontin-truesec olofmontin-truesec force-pushed the feature/azureeventhub-appmetrics branch from 3c15f22 to b832e31 Compare August 7, 2025 07:54
@olofmontin-truesec olofmontin-truesec force-pushed the feature/azureeventhub-appmetrics branch from b832e31 to 6abf4ee Compare August 18, 2025 14:47
@olofmontin-truesec olofmontin-truesec marked this pull request as ready for review August 19, 2025 07:24
@olofmontin-truesec olofmontin-truesec requested review from a team and atoulme as code owners August 19, 2025 07:24
@github-actions github-actions bot requested a review from cparkins August 19, 2025 07:24
@cparkins
Copy link
Contributor

@atoulme How can we get the workflows approved?

@atoulme
Copy link
Contributor

atoulme commented Aug 22, 2025

I have to explicitly approve each run.

@olofmontin-truesec
Copy link
Author

I have to explicitly approve each run.

That's a lot of workloads to approve 😅
Thanks a lot @atoulme 🙏🏻

@olofmontin-truesec
Copy link
Author

I see there's some issues with missing changelog and license. I'll fix those. And I can also add some test data.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 9, 2025
@olofmontin-truesec olofmontin-truesec force-pushed the feature/azureeventhub-appmetrics branch from 4733bb6 to ede41db Compare September 9, 2025 09:26
@github-actions github-actions bot removed the Stale label Sep 10, 2025
@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Sep 21, 2025
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@atoulme
Copy link
Contributor

atoulme commented Sep 21, 2025

@olofmontin-truesec please address the CI and mark ready for review again

@atoulme atoulme marked this pull request as draft September 21, 2025 23:00
@olofmontin-truesec olofmontin-truesec force-pushed the feature/azureeventhub-appmetrics branch from ede41db to 2fa4eca Compare September 26, 2025 12:24
@olofmontin-truesec olofmontin-truesec marked this pull request as ready for review September 26, 2025 12:25
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 21, 2025
@atoulme atoulme removed the Stale label Oct 24, 2025
@atoulme
Copy link
Contributor

atoulme commented Oct 24, 2025

Running CI again.

@atoulme atoulme added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Oct 24, 2025
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor PRs made by new contributors ready to merge Code review completed; ready to merge by maintainers receiver/azureeventhub

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/azureeventhub] Support app metrics

5 participants