-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(azuremonitorexporter): add support for authenticator extensions #41107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azuremonitorexporter): add support for authenticator extensions #41107
Conversation
c2b8c6f to
3b0186c
Compare
|
Please resolve conflicts and take a look at early comments. |
3b0186c to
a67ca7a
Compare
|
Hi @gravufo , thanks for the contribution. Have you validated it using real application insights? |
|
@hgaol sorry for the delay. I finally managed to run it on a kubernetes cluster on our side and tested with a real application insights and we can see that it works as expected. exporters:
azuremonitor:
connection_string: 'InstrumentationKey=<redacted>;IngestionEndpoint=https://<redacted>.in.applicationinsights.azure.com;LiveEndpoint=https://<redacted>.livediagnostics.monitor.azure.com/;ApplicationId=<redacted>'
auth:
authenticator: azureauth
sending_queue:
enabled: true
debug:
verbosity: basic
extensions:
azureauth:
scopes:
- https://monitor.azure.com/.default
workload_identity:
client_id: ${env:AZURE_CLIENT_ID}
federated_token_file: ${env:AZURE_FEDERATED_TOKEN_FILE}
tenant_id: ${env:AZURE_TENANT_ID}
health_check:
endpoint: ${env:MY_POD_IP}:13133
receivers:
otlp:
protocols:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:4318
service:
extensions:
- health_check
- azureauth
pipelines:
logs:
exporters:
- azuremonitor
- debug
receivers:
- otlp
metrics:
exporters:
- debug
receivers:
- otlp
traces:
exporters:
- azuremonitor
- debug
receivers:
- otlp
telemetry:
metrics:
readers:
- pull:
exporter:
prometheus:
host: 0.0.0.0
port: 8888 |
48daf4e to
b8e9546
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/fresh waiting on review comments. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/fresh |
|
@gravufo please rebase |
|
This discussion is still open, and we're waiting for the code-owner to decide what should be done next. Just a FYI for the next |
|
Converting to draft while conflicts are on, please fix and mark ready for review again. |
102193b to
6828153
Compare
6828153 to
9c05bfb
Compare
|
@edmocosta thanks for the suggestion. The discussion should now be closed, this can proceed to be merged. |
5d8da65 to
8633353
Compare
|
@edmocosta I'm not sure what I'm supposed to do here. I only added one dependency and it has the same version as other dependencies from the collector in the same go.mod file. |
57b8010 to
32e87aa
Compare
|
Hi @gravufo, could you please resolve the conflicts, update the branch with main, and |
35c2c9d to
6a0cdea
Compare
|
@edmocosta done but still the same error |
Signed-off-by: Christian Artin <cartin@genetec.com>
6a0cdea to
979dc32
Compare
|
Thank you for your contribution @gravufo! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
Description
Add support for authenticator extensions in Azure Monitor exporter.
Link to tracking issue
Fixes #41004
Documentation
Updated
Authentication.mdwith an example.