Skip to content

Conversation

@gravufo
Copy link
Contributor

@gravufo gravufo commented Jul 4, 2025

Description

Add support for authenticator extensions in Azure Monitor exporter.

Link to tracking issue

Fixes #41004

Documentation

Updated Authentication.md with an example.

@gravufo gravufo requested a review from a team as a code owner July 4, 2025 19:51
@gravufo gravufo requested a review from songy23 July 4, 2025 19:51
@github-actions github-actions bot requested review from hgaol and pcwiese July 4, 2025 19:52
@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch from c2b8c6f to 3b0186c Compare July 11, 2025 00:49
@atoulme
Copy link
Contributor

atoulme commented Jul 14, 2025

Please resolve conflicts and take a look at early comments.

@hgaol
Copy link
Contributor

hgaol commented Jul 15, 2025

Hi @gravufo , thanks for the contribution. Have you validated it using real application insights?

@gravufo
Copy link
Contributor Author

gravufo commented Jul 18, 2025

@hgaol sorry for the delay. I finally managed to run it on a kubernetes cluster on our side and tested with a real application insights and we can see that it works as expected.
Here is the config I used:

    exporters:
      azuremonitor:
        connection_string: 'InstrumentationKey=<redacted>;IngestionEndpoint=https://<redacted>.in.applicationinsights.azure.com;LiveEndpoint=https://<redacted>.livediagnostics.monitor.azure.com/;ApplicationId=<redacted>'
        auth:
          authenticator: azureauth
        sending_queue:
          enabled: true
      debug:
        verbosity: basic
    extensions:
      azureauth:
        scopes:
        - https://monitor.azure.com/.default
        workload_identity:
          client_id: ${env:AZURE_CLIENT_ID}
          federated_token_file: ${env:AZURE_FEDERATED_TOKEN_FILE}
          tenant_id: ${env:AZURE_TENANT_ID}
      health_check:
        endpoint: ${env:MY_POD_IP}:13133
    receivers:
      otlp:
        protocols:
          grpc:
            endpoint: 0.0.0.0:4317
          http:
            endpoint: 0.0.0.0:4318
    service:
      extensions:
      - health_check
      - azureauth
      pipelines:
        logs:
          exporters:
          - azuremonitor
          - debug
          receivers:
          - otlp
        metrics:
          exporters:
          - debug
          receivers:
          - otlp
        traces:
          exporters:
          - azuremonitor
          - debug
          receivers:
          - otlp
      telemetry:
        metrics:
          readers:
          - pull:
              exporter:
                prometheus:
                  host: 0.0.0.0
                  port: 8888

@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch 4 times, most recently from 48daf4e to b8e9546 Compare July 24, 2025 00:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 7, 2025
@gravufo
Copy link
Contributor Author

gravufo commented Aug 7, 2025

/fresh waiting on review comments.

@github-actions github-actions bot removed the Stale label Aug 8, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 23, 2025
@gravufo
Copy link
Contributor Author

gravufo commented Aug 23, 2025

/fresh

@github-actions github-actions bot removed the Stale label Aug 24, 2025
@atoulme
Copy link
Contributor

atoulme commented Sep 2, 2025

@hgaol please take another look? @gravufo please attend to the conflicts

@atoulme atoulme marked this pull request as draft September 2, 2025 15:33
@ChrsMark ChrsMark added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Oct 9, 2025
@edmocosta edmocosta removed the ready to merge Code review completed; ready to merge by maintainers label Oct 10, 2025
@ChrsMark
Copy link
Member

@gravufo please rebase

@edmocosta
Copy link
Contributor

This discussion is still open, and we're waiting for the code-owner to decide what should be done next. Just a FYI for the next ready to merge reviewer.

@atoulme atoulme marked this pull request as draft October 14, 2025 18:56
@atoulme
Copy link
Contributor

atoulme commented Oct 14, 2025

Converting to draft while conflicts are on, please fix and mark ready for review again.

@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch 2 times, most recently from 102193b to 6828153 Compare October 14, 2025 19:24
@gravufo gravufo marked this pull request as ready for review October 14, 2025 20:35
@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch from 6828153 to 9c05bfb Compare October 14, 2025 20:36
@gravufo
Copy link
Contributor Author

gravufo commented Oct 14, 2025

@edmocosta thanks for the suggestion. The discussion should now be closed, this can proceed to be merged.

@edmocosta
Copy link
Contributor

edmocosta commented Oct 15, 2025

Hi @gravufo @hgaol, could you please fix the collector dependency version on the go.mod that's failing the CI? Thanks!

@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch from 5d8da65 to 8633353 Compare October 15, 2025 14:58
@gravufo
Copy link
Contributor Author

gravufo commented Oct 15, 2025

@edmocosta I'm not sure what I'm supposed to do here. I only added one dependency and it has the same version as other dependencies from the collector in the same go.mod file.
The CI is complaining about indirect references, but those are added by go mod tidy, not manually...

@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch 2 times, most recently from 57b8010 to 32e87aa Compare October 16, 2025 18:29
@edmocosta
Copy link
Contributor

Hi @gravufo, could you please resolve the conflicts, update the branch with main, and make tidy the module? so we can double check if the error persists after the latest collector dependencies update? Thanks.

@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch 2 times, most recently from 35c2c9d to 6a0cdea Compare October 20, 2025 19:17
@gravufo
Copy link
Contributor Author

gravufo commented Oct 20, 2025

@edmocosta done but still the same error

Signed-off-by: Christian Artin <cartin@genetec.com>
@gravufo gravufo force-pushed the azuremonitorexporter-add-authenticator branch from 6a0cdea to 979dc32 Compare October 21, 2025 02:55
@edmocosta edmocosta merged commit ab7cc37 into open-telemetry:main Oct 21, 2025
188 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 21, 2025
@otelbot
Copy link
Contributor

otelbot bot commented Oct 21, 2025

Thank you for your contribution @gravufo! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter/azuremonitor] Support for HTTP authenticators

7 participants