[WIP] Add route to the span name to Phoenix socket requests #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
main
branch
5 times, most recently
from
8e44b54 to
ed19de1
Compare
danschultzer
force-pushed
the
phoenix-socket-span-description
branch
from
03b5bde to
3e9de17
Compare
danschultzer
force-pushed
the
main
branch
13 times, most recently
from
d549221 to
b03fe20
Compare
danschultzer
force-pushed
the
phoenix-socket-span-description
branch
from
3e9de17 to
d032d16
Compare
danschultzer
force-pushed
the
phoenix-socket-span-description
branch
from
d032d16 to
f4b7612
Compare
danschultzer
force-pushed
the
main
branch
3 times, most recently
from
a8381b0 to
23ab3da
Compare
danschultzer
force-pushed
the
phoenix-socket-span-description
branch
from
f4b7612 to
e31e1c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from open-telemetry/opentelemetry-erlang-contrib#438
This is WIP as it needs an upstream fix in Phoenix: phoenixframework/phoenix#6019
This will add a route template to the attributes, and use that for the span name. We may want to add code attributes from #432 though I'm not sure as we deal with both the
socketmodule that is the transport (e.g.Phoenix.Transports.WebSocket) and theuser socketmodule that's the actual socket passed into thesocketmacro.