Skip to content

Draft: feat: add equinoctial orbital elements #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Derollez
Copy link
Contributor

@Derollez Derollez commented Dec 4, 2023

  • Clean definitions and format
  • Add tests
  • Add bindings
  • Check definitions and conversions on edge cases

@Derollez Derollez self-assigned this Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Comparison is base (1be8bfd) 85.77% compared to head (2a41d58) 83.15%.

Files Patch % Lines
...rajectory/Orbit/Models/Equinoctial/Equinoctial.cpp 0.00% 198 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   85.77%   83.15%   -2.62%     
==========================================
  Files          71       72       +1     
  Lines        6304     6502     +198     
==========================================
  Hits         5407     5407              
- Misses        897     1095     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishwa2710
Copy link
Contributor

Siiiiick. I think it's worth maybe re-organizing under an Orbital Elements class under orbits, where we can house COE, Mean Orbital Elements, Equinoctial, modified equinoctial etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants