Updating benchmarks to add Rockpool JAX-accelerated benchmarks #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanMuir
commented
May 21, 2024
DylanMuir
commented
- Added several Jax and torch CUDA-graph benchmarks for Rockpool
- Updated Dockerfile to include some missed dependencies
- Added descriptive assertion error message to benchmarking function
* Updated Dockerfile to include some missed dependencies * Added descriptive assertion error message to benchmarking function
biphasic
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Hey Dylan, thanks a lot for adding the Rockpool benchmarks. Is there someone in your team that can let them run on a GPU machine to verify that they work? Alternatively I can just merge them, but there is no guarantee that the next person will be able to run them.
|
Coming back to this, I'll try to run the benchmarks on an NVIDIA/Docker enabled machine. It's never trivial to get that working 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.