coll/libnbc: add recursive doubling algorithm for MPI_Iscan #5744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot:mellanox:retest |
hjelmn
reviewed
Sep 21, 2018
| @@ -158,6 +158,15 @@ libnbc_register(void) | |||
| MCA_BASE_VAR_SCOPE_READONLY, | |||
| &libnbc_ibcast_skip_dt_decision); | |||
|
|
|||
| libnbc_iscan_algorithm = 0; | |||
| (void) mca_base_component_var_register(&mca_coll_libnbc_component.super.collm_version, | |||
There was a problem hiding this comment.
We should probably at some point add an enumerator for the algorithms so they can be selected by name.
There was a problem hiding this comment.
@hjelmn Ok, I will implement it.
Implements recursive doubling algorithm for MPI_Iscan. The algorithm preserves order of operations so it can be used both by commutative and non-commutative operations. The MCA parameter coll_libnbc_iscan_algorithm was added for dynamic algorithm selection. Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
mkurnosov
force-pushed
the
coll-iscan-recursivedoubling
branch
from
4dbe6ee to
3d43ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements recursive doubling algorithm for MPI_Iscan. The algorithm preserves order of operations so it can be used both by commutative and non-commutative operations.
The MCA parameter
coll_libnbc_iscan_algorithmwas added for dynamic algorithm selection.Signed-off-by: Mikhail Kurnosov mkurnosov@gmail.com