-
Notifications
You must be signed in to change notification settings - Fork 908
oshmem: add pkg-config files #4737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awlauria
merged 1 commit into
open-mpi:master
from
ggouaillardet:topic/oshmem_pkgconfig
May 18, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright (c) 2010 Cisco Systems, Inc. All rights reserved. | ||
| # Copyright (c) 2016 IBM Corporation. All rights reserved. | ||
| # Copyright (c) 2018 Research Organization for Information Science | ||
| # and Technology (RIST). All rights reserved. | ||
| # | ||
| Name: Open SHMEM | ||
| Description: Open MPI based Open SHMEM implementation | ||
| Version: @OSHMEM_VERSION@ | ||
| URL: http://www.open-mpi.org/ | ||
| # | ||
| prefix=@prefix@ | ||
| exec_prefix=@exec_prefix@ | ||
| includedir=@includedir@ | ||
| libdir=@libdir@ | ||
| pkgincludedir=@opalincludedir@ | ||
| # | ||
| # Note that -lopen-pal and all the EXTRA_LIBS are only necessary when | ||
| # static linking (they're pulled in by libopen-rte.so's implicit | ||
| # dependencies), so only list these in Libs.private. | ||
| # | ||
| Libs: -L${libdir} @OMPI_PKG_CONFIG_LDFLAGS@ -loshmem -l@OMPI_LIBMPI_NAME@ | ||
| Libs.private: -lopen-rte -lopen-pal @OMPI_WRAPPER_EXTRA_LIBS@ | ||
| # | ||
| Cflags: -I${includedir} @OMPI_WRAPPER_EXTRA_CPPFLAGS@ @OMPI_WRAPPER_EXTRA_CFLAGS@ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright (c) 2010 Cisco Systems, Inc. All rights reserved. | ||
| # Copyright (c) 2016 IBM Corporation. All rights reserved. | ||
| # Copyright (c) 2018 Research Organization for Information Science | ||
| # and Technology (RIST). All rights reserved. | ||
| # | ||
| Name: Open SHMEM | ||
| Description: Open MPI based Open SHMEM implementation | ||
| Version: @OSHMEM_VERSION@ | ||
| URL: http://www.open-mpi.org/ | ||
| # | ||
| prefix=@prefix@ | ||
| exec_prefix=@exec_prefix@ | ||
| includedir=@includedir@ | ||
| libdir=@libdir@ | ||
| pkgincludedir=@opalincludedir@ | ||
| # | ||
| # Note that -lopen-pal and all the EXTRA_LIBS are only necessary when | ||
| # static linking (they're pulled in by libopen-rte.so's implicit | ||
| # dependencies), so only list these in Libs.private. | ||
| # | ||
| Libs: -L${libdir} @OMPI_PKG_CONFIG_LDFLAGS@ @OMPI_WRAPPER_CXX_LIB@ -loshmem -l@OMPI_LIBMPI_NAME@ | ||
| Libs.private: -lopen-rte -lopen-pal @OMPI_WRAPPER_EXTRA_LIBS@ | ||
| # | ||
| Cflags: -I${includedir} @OMPI_WRAPPER_EXTRA_CPPFLAGS@ @OMPI_WRAPPER_EXTRA_CXXFLAGS@ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Copyright (c) 2010 Cisco Systems, Inc. All rights reserved. | ||
| # Copyright (c) 2016 IBM Corporation. All rights reserved. | ||
| # Copyright (c) 2018 Research Organization for Information Science | ||
| # and Technology (RIST). All rights reserved. | ||
| # | ||
| Name: Open SHMEM | ||
| Description: Open MPI based Open SHMEM implementation | ||
| Version: @OSHMEM_VERSION@ | ||
| URL: http://www.open-mpi.org/ | ||
| # | ||
| prefix=@prefix@ | ||
| exec_prefix=@exec_prefix@ | ||
| includedir=@includedir@ | ||
| libdir=@libdir@ | ||
| pkgincludedir=@opalincludedir@ | ||
| # | ||
| # Note that -lopen-pal and all the EXTRA_LIBS are only necessary when | ||
| # static linking (they're pulled in by libopen-rte.so's implicit | ||
| # dependencies), so only list these in Libs.private. | ||
| # | ||
| Libs: -L${libdir} @OMPI_PKG_CONFIG_LDFLAGS@ -loshmem -l@OMPI_LIBMPI_NAME@_mpifh -l@OMPI_LIBMPI_NAME@ | ||
| Libs.private: -lopen-rte -lopen-pal @OMPI_WRAPPER_EXTRA_LIBS@ | ||
| Cflags: -I${includedir} @OMPI_WRAPPER_EXTRA_CPPFLAGS@ @OMPI_WRAPPER_EXTRA_FCFLAGS@ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright (c) 2010 Cisco Systems, Inc. All rights reserved. | ||
| # Copyright (c) 2016 IBM Corporation. All rights reserved. | ||
| # Copyright (c) 2018 Research Organization for Information Science | ||
| # and Technology (RIST). All rights reserved. | ||
| # | ||
| Name: Open SHMEM | ||
| Description: Open MPI based Open SHMEM implementation | ||
| Version: @OSHMEM_VERSION@ | ||
| URL: http://www.open-mpi.org/ | ||
| # | ||
| prefix=@prefix@ | ||
| exec_prefix=@exec_prefix@ | ||
| includedir=@includedir@ | ||
| libdir=@libdir@ | ||
| pkgincludedir=@opalincludedir@ | ||
| # | ||
| # Note that -lopen-pal and all the EXTRA_LIBS are only necessary when | ||
| # static linking (they're pulled in by libopen-rte.so's implicit | ||
| # dependencies), so only list these in Libs.private. | ||
| # | ||
| Libs: -L${libdir} @OMPI_PKG_CONFIG_LDFLAGS@ -loshmem -l@OMPI_LIBMPI_NAME@ | ||
| Libs.private: @OMPI_WRAPPER_EXTRA_LIBS@ | ||
| # | ||
| Cflags: -I${includedir} @OMPI_WRAPPER_EXTRA_CPPFLAGS@ @OMPI_WRAPPER_EXTRA_CFLAGS@ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor) Does it make sense to create a
OMPI_LIBOSHMEM_NAMEto replace hardcodedoshmem?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the only issue left on this PR, I'd say that it's ready / done / can be merged.
@ggouaillardet @amaslenn ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing apart from this one from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggouaillardet If you still want this one, I'd say you're clear to merge.