[5.0.x] osc/rdma: fix compiler warnings in osc_rdma_accumulate.c #12155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 34e8f25: osc/rdma: fix compiler warnings in osc_rdma_accumu...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
@devreal could you add the cherry-pick message for CI to pass? |
janjust
approved these changes
Dec 11, 2023
|
oh I see - the main isn't merged yet, can you merge it please - I'd like to pick this up in v5.0 before rc goes out (hopefully today) |
|
Related to #12130 |
|
Change on main #12154 |
devreal
force-pushed
the
fix-osc-rdma-accumulate-compiler-warnings-v5.0.x
branch
from
34e8f25 to
f1085b4
Compare
Ensure const-correctness of the compare_addr argument to atomic CAS. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 1360be4)
devreal
force-pushed
the
fix-osc-rdma-accumulate-compiler-warnings-v5.0.x
branch
from
f1085b4 to
ca56ceb
Compare
|
Done, sorry I missed the bot message. Rebased and with proper cherry-pick message now. |
jsquyres
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure const-correctness of the compare_addr argument to atomic CAS.