Skip to content

v5.0.x: docs: update to match PRRTE v3.0.3 docs #12134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jsquyres
Copy link
Member

With this update, OMPI supports the RST docs that were released as part of PRRTE v3.0.2, but will also support the PRRTE RST docs for the upcoming v3.0.3.

Also update PRRTE submodule pointer to latest master tip to get some PRRTE RST updates and other fixes.

NOTE: This does not update PRRTE to a tagged release (because there hasn't been a 3.0.3 release yet). Hence, there will need to be at least one more PRRTE submodule update on the OMPI v5.0.x branch after this one for the OMPI v5.0.1 release.

Refs openpmix/prrte#1867
Refs #12106

This is a v5.0.x cherry pick of main PR #12120. The submodule update commit is not a cherry-pick, obviously, because it updates the prrte submodule pointer to the corresponding commit on the PRTE v3.0 branch (vs. OMPI's main PR #12120, which updated the prrte submodule pointer to the corresponding commit on the PRTE main branch).

With this update, OMPI supports the RST docs that were released as
part of PRRTE v3.0.2, but will also support the PRRTE RST docs for the
upcoming v3.0.3.

Signed-off-by: Jeff Squyres <jeff@squyres.com>
(cherry picked from commit 811a7f1)
Signed-off-by: Jeff Squyres <jeff@squyres.com>
@wenduwan
Copy link
Contributor

@jsquyres @rhc54 Does this change imply prrte 3.0.3 will come out before ompi 5.0.1 release by 12/15?

@rhc54
Copy link
Contributor

rhc54 commented Nov 28, 2023

I believe that is the plan, though I was unaware of a firm date. I'm unaware of any problems that would preclude releasing by then - though still need to test more to verify that.

@wenduwan
Copy link
Contributor

@janjust I'm good with the doc update - for the prrte submodule pointer update I want to get your opinion.

Does it make sense to you to bump it to a non-release tag? I remember we did this for 5.0.0 right before release.

@jsquyres
Copy link
Member Author

Does it make sense to you to bump it to a non-release tag? I remember we did this for 5.0.0 right before release.

IMHO, yes (obviously, since I filed this PR 😄). We should get some testing with what will soon become PRTE 3.0.3.

@janjust
Copy link
Contributor

janjust commented Nov 28, 2023

Yes, it's fine to bump it. We want to encourage testing on PRRTE/PMIX. Then if all is well, we can release in-sync with PRRTE/PMIX.

@jsquyres
Copy link
Member Author

Note that this PR does not bump the PMIx submodule; it only bumps the PRTE submodule. I have not paid attention to whatever activity has been happening in the PMIx community since Open MPI v5.0.0 was released. I.e., if the PMIx submodule needs to be bumped, there should probably be another PR for that.

@janjust janjust merged commit 15bfea8 into open-mpi:v5.0.x Nov 30, 2023
@jsquyres jsquyres deleted the pr/v5.0.x/update-prrte-and-corresponding-docs branch September 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants