v5.0.x: Correctly handle attributes on MPI_COMM_WORLD. #12072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During MPI_Finalize delete all predefined attributes from MPI_COMM_WORLD, before deleting the attributes placeholder. Note that user-defined attributes that were still attached to MPI_COMM_WORLD will leak. Fixes open-mpi#12035. Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit b79004e)
bosilca
approved these changes
Nov 15, 2023
jsquyres
deleted the
pr/v5.0.x/fix-attribute-deletion-on-comm-world-during-finalize-ie-dont-do-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During MPI_Finalize delete all predefined attributes from MPI_COMM_WORLD, before deleting the attributes placeholder. Note that user-defined attributes that were still attached to MPI_COMM_WORLD will leak.
Fixes #12035.
Signed-off-by: George Bosilca bosilca@icl.utk.edu
(cherry picked from commit b79004e)
This is the v5.0.x PR corresponding to main PR #12068