[v5.0.x] opal/ofi: package rank calculation bugfix #11775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hppritcha
approved these changes
Jun 27, 2023
|
@hppritcha Thanks for looking! Shall we merge directly? |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: a1a5b69: Merge branch 'v5.0.x' into v5.0.x
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
The current implementation has an out-of-bound bug that process_info->my_local_rank could exceed package_ranks array length. This patch eliminates package_ranks array and fixes the bug. Signed-off-by: Wenduo Wang <wenduwan@amazon.com> (cherry picked from commit 9046276)
|
Rebased branch. |
|
Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has an out-of-bound bug that process_info->my_local_rank could exceed package_ranks array length. This patch eliminates package_ranks array and fixes the bug.
Signed-off-by: Wenduo Wang wenduwan@amazon.com
(cherry picked from commit 9046276)
This commit was missed in #11739