Skip to content

feat: add a config for flag set metadata to circumvent flagd bug with metadata merging #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions flags/metadata-flags.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@
"external"
]
}
},
"metadata-flag": {
"state": "ENABLED",
"variants": {
"true": true,
"false": false
},
"defaultVariant": "false",
"targeting": {},
"metadata": {
"string": "a",
"integer": 1,
"float": 1.2,
"boolean": true
}
}
}
}
9 changes: 9 additions & 0 deletions flags/selector-flag-combined-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@
"float": 1.2,
"boolean": true
}
},
"only-set-metadata-flag": {
"state": "ENABLED",
"variants": {
"true": true,
"false": false
},
"defaultVariant": "false",
"targeting": {}
}
},
"metadata": {
Expand Down
19 changes: 0 additions & 19 deletions flags/selector-flag-metadata.json

This file was deleted.

19 changes: 0 additions & 19 deletions flags/selector-flag-set-metadata.json

This file was deleted.

25 changes: 14 additions & 11 deletions gherkin/metadata.feature
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ Feature: flag and flag set metadata
# It should be used in conjunction with the suites supplied by the OpenFeature specification.

Scenario: Returns metadata
Given an option "selector" of type "String" with value "rawflags/selector-flag-metadata.json"
And a stable flagd provider
Given a stable flagd provider
And a Boolean-flag with key "metadata-flag" and a default value "true"
When the flag was evaluated with details
Then the resolved metadata should contain
Expand All @@ -18,20 +17,24 @@ Feature: flag and flag set metadata
| boolean | Boolean | true |

Scenario: Returns flag set metadata
Given an option "selector" of type "String" with value "rawflags/selector-flag-set-metadata.json"
And a stable flagd provider
And a Boolean-flag with key "set-metadata-flag" and a default value "true"
Given an option "selector" of type "String" with value "rawflags/selector-flag-combined-metadata.json"
And a metadata flagd provider
And a Boolean-flag with key "only-set-metadata-flag" and a default value "true"
When the flag was evaluated with details
Then the resolved metadata should contain
| key | metadata_type | value |
| string | String | a |
| integer | Integer | 1 |
| float | Float | 1.2 |
| boolean | Boolean | true |
| key | metadata_type | value |
| string | String | b |
| integer | Integer | 2 |
| float | Float | 2.2 |
| boolean | Boolean | false |
| flag-set-string | String | c |
| flag-set-integer | Integer | 3 |
| flag-set-float | Float | 3.2 |
| flag-set-boolean | Boolean | false |

Scenario: Flag metadata overwrites flag set metadata
Given an option "selector" of type "String" with value "rawflags/selector-flag-combined-metadata.json"
And a stable flagd provider
And a metadata flagd provider
And a Boolean-flag with key "combined-metadata-flag" and a default value "true"
When the flag was evaluated with details
Then the resolved metadata should contain
Expand Down
8 changes: 0 additions & 8 deletions launchpad/configs/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
"uri": "rawflags/selector-flags.json",
"provider": "file"
},
{
"uri": "rawflags/selector-flag-metadata.json",
"provider": "file"
},
{
"uri": "rawflags/selector-flag-set-metadata.json",
"provider": "file"
},
{
"uri": "rawflags/selector-flag-combined-metadata.json",
"provider": "file"
Expand Down
8 changes: 8 additions & 0 deletions launchpad/configs/metadata.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"sources": [
{
"uri": "rawflags/selector-flag-combined-metadata.json",
"provider": "file"
}
]
}
8 changes: 0 additions & 8 deletions launchpad/configs/ssl.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,6 @@
"uri": "rawflags/selector-flags.json",
"provider": "file"
},
{
"uri": "rawflags/selector-flag-metadata.json",
"provider": "file"
},
{
"uri": "rawflags/selector-flag-set-metadata.json",
"provider": "file"
},
{
"uri": "rawflags/selector-flag-combined-metadata.json",
"provider": "file"
Expand Down