feat: listening for logs before returning a http status code #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
chrfwow
suggested changes
Feb 19, 2025
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/launchpad-wait-for-logs
branch
from
8b3140b to
29197ff
Compare
chrfwow
reviewed
Feb 19, 2025
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
|
Since my go is not that great and to clarify, this PR does not fix the issue with delayed restarts, or am I missing something? |
it is not the goal to fix delayed restarts. the goal is to return the request not immediately after the start command was triggered, but to wait for a log message of flagd to return the status code and the request. Before it was:
now it is:
this way we do not need the sleep in the tests anymore after hitting this endpoint. |
aepfli
force-pushed
the
feat/launchpad-wait-for-logs
branch
2 times, most recently
from
6857f9c to
16001f5
Compare
|
changed the whole pr, now this is a full blown refactoring/restructuring of launchpad for easier usage:
|
aepfli
force-pushed
the
feat/launchpad-wait-for-logs
branch
from
16001f5 to
6cbed8e
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/launchpad-wait-for-logs
branch
from
6cbed8e to
3e4bd1e
Compare
chrfwow
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #222